From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: fix a link in contribution guide
Date: Fri, 6 Jan 2017 15:40:19 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2026A9D1C@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20170106012232.20246-1-yskoh@mellanox.com>
> -----Original Message-----
> From: Yongseok Koh [mailto:yskoh@mellanox.com]
> Sent: Friday, January 6, 2017 1:23 AM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Yongseok Koh <yskoh@mellanox.com>
> Subject: [PATCH] doc: fix a link in contribution guide
>
> A referenced document in the Linux Kernel has been moved to a sub-
> directory.
>
Hi Yongseok,
Thanks for that. It is interesting to see kernel community move to RST/Sphinx.
>
> The DPDK development process is modelled (loosely) on the Linux Kernel
> development model so it is worth reading the Linux kernel guide on
> submitting patches:
> -`How to Get Your Change Into the Linux Kernel
> <http://www.kernel.org/doc/Documentation/SubmittingPatches>`_.
> +`How to Get Your Change Into the Linux Kernel
> <http://www.kernel.org/doc/Documentation/process/submitting-
> patches.rst>`_.
It would be better to use the Html rendered link here:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> The rationale for many of the DPDK guidelines is explained in greater
> detail in the kernel guidelines.
>
>
> @@ -192,7 +192,7 @@ Here are some guidelines for the body of a commit
> message:
> git commit --signoff # or -s
>
> The purpose of the signoff is explained in the
> - `Developer's Certificate of Origin
> <http://www.kernel.org/doc/Documentation/SubmittingPatches>`_
> + `Developer's Certificate of Origin
> + <http://www.kernel.org/doc/Documentation/process/submitting-patches.rs
> + t>`_
And here:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
John
next prev parent reply other threads:[~2017-01-06 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 1:22 Yongseok Koh
2017-01-06 15:40 ` Mcnamara, John [this message]
2017-01-06 22:40 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
2017-01-09 8:33 ` Mcnamara, John
2017-01-17 16:04 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2026A9D1C@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).