From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Wiles, Keith" <keith.wiles@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "iryzhov@nfware.com" <iryzhov@nfware.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v3] doc: use corelist instead of coremask
Date: Tue, 21 Feb 2017 15:53:36 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2026D3BA8@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20170210140103.74690-1-keith.wiles@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Keith Wiles
> Sent: Friday, February 10, 2017 2:01 PM
> To: dev@dpdk.org
> Cc: iryzhov@nfware.com; thomas.monjalon@6wind.com
> Subject: [dpdk-dev] [PATCH v3] doc: use corelist instead of coremask
>
> The coremask option in DPDK is difficult to use and we should be
> promoting the use of the corelist (-l) option. The patch
> adjusts the docs to use -l EAL option instead of the -c option.
>
> The patch only changes the docs and not the code as the -c option
> will continue to exist unless it is removed in the future. The -c
> option should be kept to maintain backward compatibility.
Hi Keith,
Thanks for that. It is a good change and we should make sure that any
new additions to the docs conform to this.
Just to note that the patch no longer applies cleanly and that there
may be some additional "-c" documentation that has been added and some
that has been removed.
Also, a few of the conversation aren't quite right, see below.
> diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst
> index 9a2e973..3762c60 100644
> --- a/doc/guides/nics/mlx4.rst
> +++ b/doc/guides/nics/mlx4.rst
> @@ -343,7 +343,7 @@ devices managed by librte_pmd_mlx4.
>
> .. code-block:: console
>
> - testpmd -c 0xff00 -n 4 -w 0000:83:00.0 -w 0000:84:00.0 -- --rxq=2 --txq=2 -i
> + testpmd -l 8-11 -n 4 -w 0000:83:00.0 -w 0000:84:00.0 -- --rxq=2 --txq=2 -i
testpmd -l 8-15 -n 4 -w 0000:83:00.0 -w 0000:84:00.0 -- --rxq=2 --txq=2 -i
>
> Example output:
>
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index 09922a0..5f6e594 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -382,7 +382,7 @@ ConnectX-4/ConnectX-5 devices managed by librte_pmd_mlx5.
>
> .. code-block:: console
>
> - testpmd -c 0xff00 -n 4 -w 05:00.0 -w 05:00.1 -w 06:00.0 -w 06:00.1 -- --rxq=2 --txq=2 -i
> + testpmd -l 8-11 -n 4 -w 05:00.0 -w 05:00.1 -w 06:00.0 -w 06:00.1 -- --rxq=2 --txq=2 -i
testpmd -l 8-15 -n 4 -w 05:00.0 -w 05:00.1 -w 06:00.0 -w 06:00.1 -- --rxq=2 --txq=2 -i
> ...
> --- a/doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst
> +++ b/doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst
> @@ -365,7 +365,7 @@ Device names and bonding options must be separated by commas as shown below:
>
> .. code-block:: console
>
> - $RTE_TARGET/app/testpmd -c f -n 4 --vdev 'net_bond0,bond_opt0=..,bond opt1=..'--vdev 'net_bond1,bond _opt0=..,bond_opt1=..'
> + $RTE_TARGET/app/testpmd -l 0-3 -n 4 --vdev 'net_bond0,bond_opt0=..,bond opt1=..'--vdev 'net_bond1,bond _opt0=..,bond_opt1=..'
>
> Link Bonding EAL Options
> ^^^^^^^^^^^^^^^^^^^^^^^^
> @@ -465,22 +465,22 @@ Create a bonded device in round robin mode with two slaves specified by their PC
>
> .. code-block:: console
>
> - $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'net_bond0,mode=0, slave=0000:00a:00.01,slave=0000:004:00.00' -- --port-topology=chained
> + $RTE_TARGET/app/testpmd -l 0-3' -n 4 --vdev 'net_bond0,mode=0, slave=0000:00a:00.01,slave=0000:004:00.00' -- --port-topology=chained
$RTE_TARGET/app/testpmd -l 0-3 -n 4 --vdev 'net_bond0,mode=0, slave=0000:00a:00.01,slave=0000:004:00.00' -- --port-topology=chained
> diff --git a/doc/guides/xen/pkt_switch.rst b/doc/guides/xen/pkt_switch.rst
> index 0b4ddfd..717a04b 100644
> --- a/doc/guides/xen/pkt_switch.rst
> +++ b/doc/guides/xen/pkt_switch.rst
> @@ -331,7 +331,7 @@ Building and Running the Switching Backend
>
> ...
> .. code-block:: console
>
> - ./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4 --vdev="net_xenvirt0,mac=00:00:00:00:00:22" -- -i --eth-peer=0,00:00:00:00:00:33
> + ./x86_64-native-linuxapp-gcc/app/testpmd -l 0-7 -n 4 --vdev="net_xenvirt0,mac=00:00:00:00:00:22" -- -i --eth-peer=0,00:00:00:00:00:33
>
./x86_64-native-linuxapp-gcc/app/testpmd -l 0-3 -n 4 --vdev="net_xenvirt0,mac=00:00:00:00:00:22" -- -i --eth-peer=0,00:00:00:00:00:33
next prev parent reply other threads:[~2017-02-21 15:53 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 18:14 [dpdk-dev] [PATCH 00/11] moving away from coremask to corelist Keith Wiles
2017-02-09 18:14 ` [dpdk-dev] [PATCH 01/11] doc/cryptodev: use corelist instead of coremask Keith Wiles
2017-02-09 18:14 ` [dpdk-dev] [PATCH 02/11] doc/faq: " Keith Wiles
2017-02-09 18:14 ` [dpdk-dev] [PATCH 03/11] doc/freebsd: " Keith Wiles
2017-02-09 18:14 ` [dpdk-dev] [PATCH 04/11] doc/howto: " Keith Wiles
2017-02-09 23:00 ` Igor Ryzhov
2017-02-09 23:20 ` Wiles, Keith
2017-02-09 18:14 ` [dpdk-dev] [PATCH 05/11] doc/linux: " Keith Wiles
2017-02-09 18:14 ` [dpdk-dev] [PATCH 06/11] doc/nics: " Keith Wiles
2017-02-09 18:14 ` [dpdk-dev] [PATCH 07/11] doc/prog_guide: " Keith Wiles
2017-02-09 18:14 ` [dpdk-dev] [PATCH 08/11] doc/testpmd: " Keith Wiles
2017-02-09 18:14 ` [dpdk-dev] [PATCH 09/11] doc/cryptoperf: " Keith Wiles
2017-02-09 18:14 ` [dpdk-dev] [PATCH 10/11] doc/xen: " Keith Wiles
2017-02-09 18:14 ` [dpdk-dev] [PATCH 11/11] doc/sample_app: " Keith Wiles
2017-02-09 23:42 ` [dpdk-dev] [PATCH v2 00/11] moving away from coremask to corelist Keith Wiles
2017-02-10 8:46 ` Thomas Monjalon
2017-02-10 13:47 ` Wiles, Keith
2017-02-09 23:42 ` [dpdk-dev] [PATCH v2 01/11] doc/cryptodev: use corelist instead of coremask Keith Wiles
2017-02-09 23:42 ` [dpdk-dev] [PATCH v2 02/11] doc/faq: " Keith Wiles
2017-02-09 23:42 ` [dpdk-dev] [PATCH v2 03/11] doc/freebsd: " Keith Wiles
2017-02-09 23:42 ` [dpdk-dev] [PATCH v2 04/11] doc/howto: " Keith Wiles
2017-02-09 23:42 ` [dpdk-dev] [PATCH v2 05/11] doc/linux: " Keith Wiles
2017-02-09 23:42 ` [dpdk-dev] [PATCH v2 06/11] doc/nics: " Keith Wiles
2017-02-09 23:42 ` [dpdk-dev] [PATCH v2 07/11] doc/prog_guide: " Keith Wiles
2017-02-09 23:42 ` [dpdk-dev] [PATCH v2 08/11] doc/testpmd: " Keith Wiles
2017-02-09 23:42 ` [dpdk-dev] [PATCH v2 09/11] doc/cryptoperf: " Keith Wiles
2017-02-09 23:42 ` [dpdk-dev] [PATCH v2 10/11] doc/xen: " Keith Wiles
2017-02-09 23:42 ` [dpdk-dev] [PATCH v2 11/11] doc/sample_app: " Keith Wiles
2017-02-10 14:01 ` [dpdk-dev] [PATCH v3] doc: " Keith Wiles
2017-02-21 15:53 ` Mcnamara, John [this message]
2017-02-21 17:38 ` [dpdk-dev] [PATCH v4] " Keith Wiles
2017-02-22 10:20 ` Mcnamara, John
2017-02-27 19:13 ` [dpdk-dev] [PATCH v5] " Keith Wiles
2017-02-28 17:14 ` Mcnamara, John
2017-03-01 19:40 ` Thomas Monjalon
2017-03-01 20:03 ` Wiles, Keith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2026D3BA8@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=iryzhov@nfware.com \
--cc=keith.wiles@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).