From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Billy McFall <bmcfall@redhat.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring
Date: Tue, 7 Mar 2017 16:42:35 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2332535A9@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <20170127183800.27466-2-bmcfall@redhat.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Billy McFall
> Sent: Friday, January 27, 2017 6:38 PM
> To: thomas.monjalon@6wind.com; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> olivier.matz@6wind.com
> Cc: dev@dpdk.org; Billy McFall <bmcfall@redhat.com>
> Subject: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed
> buffers in Tx ring
>
Hi Billy,
Thanks for this. Some minor comments below.
>
>
> +Driver Cache
> +~~~~~~~~~~~~
I think this could be at the same level as the "Local Cache" earlier in
the doc.
> +
> +In addition to the a core’s local cache, many of the drivers don't
The apostrophe after core is non-ascii. That can mess with the PDF output.
> +release the mbuf back to the mempool, or local cache, immediately after
> the packet has been transmitted.
> +Instead, they leave the mbuf in their txRing and either perform a bulk
I'd suggest s/txRing/Tx ring/ here and below.
> +release when the tx_rs_thresh has been crossed or free the mbuf when a
You should fixed width quote ``tx_rs_thresh`` here and below.
> slot in the txRing is needed.
> +
> +An application can request the driver to release used mbufs with the
> ``rte_eth_tx_done_cleanup()`` API.
> +This API requests the driver to release mbufs that are no longer in
> +use, independent of whether or not the tx_rs_thresh has been crossed.
> +There are two scenarios when an application may want the mbuf back
> immediately:
s/back/released/ maybe?
> +
> +* When a given packet needs to be sent to multiple destination interfaces
> (either for Layer 2 flooding or Layer 3 multi-cast).
> + One option is to make a copy of the packet or a copy of the header
> portion that needs to manipulated.
s/to/to be/
John
next prev parent reply other threads:[~2017-03-07 16:43 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 16:01 [dpdk-dev] [PATCH v3 0/3] " Billy McFall
2017-01-20 16:01 ` [dpdk-dev] [PATCH v3 1/3] ethdev: " Billy McFall
2017-01-20 16:01 ` [dpdk-dev] [PATCH v3 2/3] net/e1000: e1000 igb support to free consumed buffers Billy McFall
2017-01-22 3:47 ` Lu, Wenzhuo
2017-01-23 13:49 ` Billy McFall
2017-01-24 0:42 ` Lu, Wenzhuo
2017-01-20 16:01 ` [dpdk-dev] [PATCH v3 3/3] net/vhost: vHost " Billy McFall
2017-01-23 15:25 ` [dpdk-dev] [PATCH v3 0/3] new API to free consumed buffers in Tx ring Thomas Monjalon
2017-01-23 21:13 ` [dpdk-dev] [PATCH v4 " Billy McFall
2017-01-23 21:13 ` [dpdk-dev] [PATCH v4 1/3] ethdev: " Billy McFall
2017-01-23 21:13 ` [dpdk-dev] [PATCH v4 2/3] net/e1000: e1000 igb support to free consumed buffers Billy McFall
2017-01-23 21:13 ` [dpdk-dev] [PATCH v4 3/3] net/vhost: vHost " Billy McFall
2017-01-27 18:37 ` [dpdk-dev] [PATCH v5 0/3] new API to free consumed buffers in Tx ring Billy McFall
2017-01-27 18:37 ` [dpdk-dev] [PATCH v5 1/3] ethdev: " Billy McFall
2017-02-27 13:48 ` Thomas Monjalon
2017-03-07 14:29 ` Billy McFall
2017-03-07 16:03 ` Thomas Monjalon
2017-03-09 15:49 ` Billy McFall
2017-03-09 17:11 ` Thomas Monjalon
2017-03-07 16:35 ` Mcnamara, John
2017-03-07 16:42 ` Mcnamara, John [this message]
2017-01-27 18:37 ` [dpdk-dev] [PATCH v5 2/3] net/e1000: e1000 igb support to free consumed buffers Billy McFall
2017-02-27 13:49 ` Thomas Monjalon
2017-02-28 1:07 ` Lu, Wenzhuo
2017-01-27 18:38 ` [dpdk-dev] [PATCH v5 3/3] net/vhost: vHost " Billy McFall
2017-02-27 13:50 ` Thomas Monjalon
2017-02-28 6:41 ` Yuanhan Liu
2017-03-01 10:15 ` Maxime Coquelin
2017-03-07 21:59 ` [dpdk-dev] [PATCH v5 0/3] new API to free consumed buffers in Tx ring Thomas Monjalon
2017-03-09 20:51 ` [dpdk-dev] [PATCH v6 " Billy McFall
2017-03-09 20:51 ` [dpdk-dev] [PATCH v6 1/3] ethdev: " Billy McFall
2017-03-15 10:29 ` Olivier Matz
2017-03-15 15:01 ` Billy McFall
2017-03-15 10:30 ` Thomas Monjalon
2017-03-09 20:51 ` [dpdk-dev] [PATCH v6 2/3] net/e1000: e1000 igb support to free consumed buffers Billy McFall
2017-03-13 3:17 ` Lu, Wenzhuo
2017-03-09 20:51 ` [dpdk-dev] [PATCH v6 3/3] net/vhost: vHost " Billy McFall
2017-03-15 10:27 ` Thomas Monjalon
2017-03-15 18:02 ` [dpdk-dev] [PATCH v7 0/3] new API to free consumed buffers in Tx ring Billy McFall
2017-03-15 18:02 ` [dpdk-dev] [PATCH v7 1/3] ethdev: " Billy McFall
2017-03-23 10:37 ` Olivier MATZ
2017-03-23 13:32 ` Billy McFall
2017-03-24 12:46 ` Olivier Matz
2017-03-24 13:18 ` Billy McFall
2017-03-24 13:30 ` Olivier Matz
2017-03-15 18:02 ` [dpdk-dev] [PATCH v7 2/3] net/e1000: e1000 igb support to free consumed buffers Billy McFall
2017-03-15 18:02 ` [dpdk-dev] [PATCH v7 3/3] net/vhost: vHost " Billy McFall
2017-03-15 20:25 ` [dpdk-dev] [PATCH v7 0/3] new API to free consumed buffers in Tx ring Wiles, Keith
2017-03-24 18:55 ` [dpdk-dev] [PATCH v8 " Billy McFall
2017-03-24 18:55 ` [dpdk-dev] [PATCH v8 1/3] ethdev: " Billy McFall
2017-03-24 18:55 ` [dpdk-dev] [PATCH v8 2/3] net/e1000: e1000 igb support to free consumed buffers Billy McFall
2017-03-24 18:55 ` [dpdk-dev] [PATCH v8 3/3] net/vhost: vHost " Billy McFall
2017-03-27 15:20 ` [dpdk-dev] [PATCH v8 0/3] new API to free consumed buffers in Tx ring Thomas Monjalon
2017-04-19 16:25 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2332535A9@IRSMSX104.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=bmcfall@redhat.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=thomas.monjalon@6wind.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).