From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: reformat crypto drivers overview
Date: Thu, 23 Mar 2017 08:41:53 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE233273242@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1490199328-12165-1-git-send-email-pablo.de.lara.guarch@intel.com>
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Wednesday, March 22, 2017 4:15 PM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org; De Lara Guarch,
> Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] doc: reformat crypto drivers overview
>
> Follow the approach in the network devices overview, for the feature
> matrix, so it improves readibility and maintainability.
>
There are pep8 warnings that should be fixed. Mainly for long lines:
$ pep8 doc/guides/conf.py
doc/guides/conf.py:318:80: E501 line too long (109 > 79 characters)
doc/guides/conf.py:320:80: E501 line too long (105 > 79 characters)
doc/guides/conf.py:321:80: E501 line too long (81 > 79 characters)
doc/guides/conf.py:322:80: E501 line too long (108 > 79 characters)
doc/guides/conf.py:324:80: E501 line too long (122 > 79 characters)
doc/guides/conf.py:326:80: E501 line too long (102 > 79 characters)
Apart from that it is a good change and a nice generalization of the
table building approach.
With the above fixed:
Acked-by: John McNamara <john.mcnamara@intel.com>
next prev parent reply other threads:[~2017-03-23 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 16:15 Pablo de Lara
2017-03-23 8:41 ` Mcnamara, John [this message]
2017-03-23 11:38 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2017-03-23 15:35 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE233273242@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).