From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] doc: fix description on intel VFs
Date: Sun, 2 Apr 2017 11:36:44 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2332ADE55@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1491092626-126897-1-git-send-email-jingjing.wu@intel.com>
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Sunday, April 2, 2017 1:24 AM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; stable@dpdk.org
> Subject: [PATCH] doc: fix description on intel VFs
>
> This patch corrects the description on Physical and Virtual Function
> Infrastructure of Intel NICs. The RSS part description should belong to
> ixgbe but not i40e.
> This patch also add more notes to describe the queue number on Intel
> X710/XL710 NICs.
>
> Fixes: b9fcaeec5fc0 ("doc: add ixgbe VF RSS guide")
> ...
> +
> + * If the max number of VFs(max_vfs) is set in the range of 1 to 32:
> +
> + If the number of Rx queues is specified as 4(e.g. `--rxq=4` in
> testpmd), then there are totally 32
> + pools(ETH_32_POOLS), and each VF could have 4 Rx queues;
I know you are only moving this section of the docs but there are a few issues
that are worth fixing while you are doing it.
The rxq values require 2 backquote: ``--rxq=4`` in several places.
Also, make should that there is a space before each open parenthesis in this
section. There are several places where there isn't one: pools(ETH_32_POOLS),
next prev parent reply other threads:[~2017-04-02 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-02 0:23 Jingjing Wu
2017-04-02 11:36 ` Mcnamara, John [this message]
2017-05-22 7:54 Jingjing Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2332ADE55@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).