From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Shijith Thotton <shijith.thotton@caviumnetworks.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and testing of PMD
Date: Fri, 7 Apr 2017 09:23:31 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2332B3003@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20170407070724.GA5581@localhost.localdomain>
> -----Original Message-----
> From: Shijith Thotton [mailto:shijith.thotton@caviumnetworks.com]
> Sent: Friday, April 7, 2017 8:07 AM
> To: Thomas Monjalon <thomas.monjalon@6wind.com>
> Cc: Mcnamara, John <john.mcnamara@intel.com>; dev@dpdk.org; Yigit, Ferruh
> <ferruh.yigit@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and
> testing of PMD
>
> On Thu, Apr 06, 2017 at 08:30:21PM +0200, Thomas Monjalon wrote:
> > 2017-04-06 13:21, Shijith Thotton:
> > > Add a section in NIC drivers documentation to explain compiling and
> > > testing of a PMD. It also mentions about host setup, which is
> > > required before running testpmd.
> > >
> > > Add label "testpmd_ug" to refer user guide.
> > >
> > > Signed-off-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
> >
> > It is really good to factorize documentation.
> >
> > This doc is about testpmd in Linux
> > and does not refer to FreeBSD.
> > Do we assume to take Linux as the reference?
>
> I can submit v2 with a subsection for running testpmd in FreeBSD.
Hi,
> I can submit v2 with a subsection for running testpmd in FreeBSD.
I don't think that is necessary. You patch already calls out the
Linux and FreeBSD Getting Started Guides. I think that is enough.
@tmonjalo
For me this new "Compiling and testing a PMD for a NIC" section
is a way of avoiding duplicate sections in the NIC guides. I don't
think it has to be a definitive guide to TestPMD.
As and aside, I would like to do something similar with the sample
app guides, i.e., have one section on compilation that the other
app guides can refer to. I'll try to add that in the next release.
So for me this patchset is okay as it is.
John
next prev parent reply other threads:[~2017-04-07 9:23 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 15:03 [dpdk-dev] [RFC 0/2] doc: consolidate common part among PMD docs Shijith Thotton
2017-04-01 15:03 ` [dpdk-dev] [RFC 1/2] doc: add doc with steps to build PMD and run testpmd Shijith Thotton
2017-04-02 12:11 ` Mcnamara, John
2017-04-02 12:13 ` Mcnamara, John
2017-04-03 8:05 ` Shijith Thotton
2017-04-01 15:04 ` [dpdk-dev] [RFC 2/2] doc: include PMD build and run file in liquidio doc Shijith Thotton
2017-04-02 12:15 ` Mcnamara, John
2017-04-06 7:51 ` [dpdk-dev] [PATCH 0/8] doc: consolidate common part among PMD docs Shijith Thotton
2017-04-06 7:51 ` [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and testing of PMD Shijith Thotton
2017-04-06 16:43 ` Mcnamara, John
2017-04-06 18:30 ` Thomas Monjalon
2017-04-07 7:07 ` Shijith Thotton
2017-04-07 9:23 ` Mcnamara, John [this message]
2017-04-07 9:34 ` Thomas Monjalon
2017-04-07 9:42 ` Jerin Jacob
2017-04-07 10:10 ` Shijith Thotton
2017-04-06 7:51 ` [dpdk-dev] [PATCH 2/8] doc: refer PMD compile and test section from liquidio doc Shijith Thotton
2017-04-06 16:43 ` Mcnamara, John
2017-04-06 7:51 ` [dpdk-dev] [PATCH 3/8] doc: refer PMD compile and test section from bnx2x doc Shijith Thotton
2017-04-06 16:45 ` Mcnamara, John
2017-04-06 7:51 ` [dpdk-dev] [PATCH 4/8] doc: refer PMD compile and test section from cxgbe doc Shijith Thotton
2017-04-06 16:45 ` Mcnamara, John
2017-04-06 7:51 ` [dpdk-dev] [PATCH 5/8] doc: refer PMD compile and test section from ena doc Shijith Thotton
2017-04-06 16:45 ` Mcnamara, John
2017-04-06 7:51 ` [dpdk-dev] [PATCH 6/8] doc: refer PMD compile and test section from i40e doc Shijith Thotton
2017-04-06 16:46 ` Mcnamara, John
2017-04-06 7:51 ` [dpdk-dev] [PATCH 7/8] doc: refer PMD compile and test section from nfp doc Shijith Thotton
2017-04-06 16:46 ` Mcnamara, John
2017-04-06 7:51 ` [dpdk-dev] [PATCH 8/8] doc: refer PMD compile and test section from qede doc Shijith Thotton
2017-04-06 16:46 ` Mcnamara, John
2017-04-11 18:56 ` [dpdk-dev] [PATCH v2 00/10] doc: consolidate common part among PMD docs Shijith Thotton
2017-04-11 18:56 ` [dpdk-dev] [PATCH v2 01/10] doc: add doc to explain compiling and testing of PMD Shijith Thotton
2017-04-11 18:56 ` [dpdk-dev] [PATCH v2 02/10] doc: refer PMD compile and test section from ark doc Shijith Thotton
2017-04-11 18:56 ` [dpdk-dev] [PATCH v2 03/10] doc: refer PMD compile and test section from bnx2x doc Shijith Thotton
2017-04-11 18:56 ` [dpdk-dev] [PATCH v2 04/10] doc: refer PMD compile and test section from cxgbe doc Shijith Thotton
2017-04-11 18:56 ` [dpdk-dev] [PATCH v2 05/10] doc: refer PMD compile and test section from ena doc Shijith Thotton
2017-04-11 18:56 ` [dpdk-dev] [PATCH v2 06/10] doc: refer PMD compile and test section from i40e doc Shijith Thotton
2017-04-11 18:56 ` [dpdk-dev] [PATCH v2 07/10] doc: refer PMD compile and test section from liquidio doc Shijith Thotton
2017-04-11 18:56 ` [dpdk-dev] [PATCH v2 08/10] doc: refer PMD compile and test section from nfp doc Shijith Thotton
2017-04-11 18:56 ` [dpdk-dev] [PATCH v2 09/10] doc: refer PMD compile and test section from qede doc Shijith Thotton
2017-04-11 18:56 ` [dpdk-dev] [PATCH v2 10/10] doc: refer PMD compile and test section from thunderx doc Shijith Thotton
2017-04-12 15:23 ` [dpdk-dev] [PATCH v2 00/10] doc: consolidate common part among PMD docs Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2332B3003@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=shijith.thotton@caviumnetworks.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).