From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Yang, Zhiyong" <zhiyong.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] doc: update virtio doc
Date: Wed, 10 May 2017 09:58:24 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2332CAD72@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1494397104-56154-1-git-send-email-zhiyong.yang@intel.com>
> -----Original Message-----
> From: Yang, Zhiyong
> Sent: Wednesday, May 10, 2017 7:18 AM
> To: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
> Cc: yuanhan.liu@linux.intel.com; maxime.coquelin@redhat.com; Yang, Zhiyong
> <zhiyong.yang@intel.com>
> Subject: [PATCH] doc: update virtio doc
>
> Add more explanations about vring size changes and virtio_header size.
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
> doc/guides/nics/virtio.rst | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index
> 91bedea..36ddd08 100644
> --- a/doc/guides/nics/virtio.rst
> +++ b/doc/guides/nics/virtio.rst
> @@ -41,8 +41,8 @@ The DPDK extends kni to support vhost raw socket
> interface, which enables vhost to directly read/ write packets from/to a
> physical port.
> With this enhancement, virtio could achieve quite promising performance.
>
> -In future release, we will also make enhancement to vhost backend, -
> releasing peak performance of virtio PMD driver.
> +In future release, we will also make enhancement to vhost backend.
> +Peak performance of virtio PMD driver will be released with every release
> version since DPDK 17.02 release.
Hi,
There have been great performance improvements in Virtio in the last few
releases. However, we can't really promise that is will improve in every
release. I'd suggest removing these two lines and the previous line
starting with "With this enhancement, virtio could ...".
>
> ...
>
> -* RTE_PKTMBUF_HEADROOM should be defined larger than sizeof(struct
> virtio_net_hdr), which is 10 bytes.
> +* RTE_PKTMBUF_HEADROOM should be defined
> + larger than sizeof(struct virtio_net_hdr), which is 10 bytes, when
> using non-mergeable.
> + larger than sizeof(struct virtio_net_hdr_mrg_rxbuf), which is 12
> bytes when mergeable or F_VERSION_1
> + is set.
>
All constants and struct names should be ```` quoted. Like this:
* ``RTE_PKTMBUF_HEADROOM`` should be defined larger than
``sizeof(struct virtio_net_hdr)``, which is 10 bytes, when using
non-mergeable or larger than ``sizeof(struct virtio_net_hdr_mrg_rxbuf)``,
which is 12 bytes when mergeable or ``F_VERSION_1`` is set.
John
next prev parent reply other threads:[~2017-05-10 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 6:18 Zhiyong Yang
2017-05-10 9:58 ` Mcnamara, John [this message]
2017-05-10 10:11 ` Yang, Zhiyong
2017-05-11 2:16 ` [dpdk-dev] [PATCH v2] doc: update virtio vring size and virtio_header size Zhiyong Yang
2017-06-30 14:43 ` Mcnamara, John
2017-07-01 23:31 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2332CAD72@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=yuanhan.liu@linux.intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).