DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Carrillo, Erik G" <erik.g.carrillo@intel.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] doc: add new targets to "make help" output
Date: Mon, 26 Jun 2017 15:38:29 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23ED14C5E@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <1496767364-19421-1-git-send-email-erik.g.carrillo@intel.com>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gabriel Carrillo
> Sent: Tuesday, June 6, 2017 5:43 PM
> To: thomas@monjalon.net
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] doc: add new targets to "make help" output
> 
> Commit aafaea3d3b70 ("devtools: add tags and cscope index generation")
> introduced new make targets. This change updates the help target output to
> reflect the additions.
> 
> Signed-off-by: Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
>  doc/build-sdk-quick.txt | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
> 
> diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt index
> 8d41052..8ed9d80 100644
> --- a/doc/build-sdk-quick.txt
> +++ b/doc/build-sdk-quick.txt
> @@ -1,16 +1,17 @@
>  Basic build
>  	make config T=x86_64-native-linuxapp-gcc && make  Build commands
> -	config           get configuration from target template (T=)
> -	all              same as build (default rule)
> -	build            build in a configured directory
> -	clean            remove files but keep configuration
> -	install T=       configure, build and install a target in DESTDIR
> -	install          install optionally staged in DESTDIR
> -	examples         build examples for given targets (T=)
> -	examples_clean   clean examples for given targets (T=)
> -	test             compile tests and run basic unit tests
> -	test-*           run specific subset of unit tests
> +	config			get configuration from target template (T=)
> +	all			same as build (default rule)
> +	build			build in a configured directory
> +	clean			remove files but keep configuration
> +	install T=		configure, build and install a target in DESTDIR
> +	install			install optionally staged in DESTDIR
> +	examples   		build examples for given targets (T=)
> +	examples_clean		clean examples for given targets (T=)
> +	test                  	compile tests and run basic unit tests
> +	test-*               	run specific subset of unit tests
> +	tags|gtags|cscope [T=]  generate tags or cscope index
>  Build variables
>  	EXTRA_CPPFLAGS   preprocessor options
>  	EXTRA_CFLAGS     compiler options
> --

Hi,

Thanks for this. Unfortunately there is a mix of tabs and spaces used
for the alignment so the output cat look funny depending on tab
settings.

I know that Thomas commented that the previous version was too verbose
but it looked better to me. Maybe we could compromise on:

	tags|gtags T=    generate tags/gtags for given targets (T=)
	cscope T=        generate cscope database for given targets (T=)

John

  reply	other threads:[~2017-06-26 15:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 21:43 [dpdk-dev] [PATCH] " Gabriel Carrillo
2017-06-06  6:40 ` Thomas Monjalon
2017-06-06 16:42 ` [dpdk-dev] [PATCH v2] " Gabriel Carrillo
2017-06-26 15:38   ` Mcnamara, John [this message]
2017-07-07 17:00     ` Carrillo, Erik G
2017-07-07 17:09 ` [dpdk-dev] [PATCH v3] " Gabriel Carrillo
2017-08-03 22:50   ` Thomas Monjalon
2017-08-05  9:08     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE23ED14C5E@IRSMSX104.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).