DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Tom Barbette <tom.barbette@ulg.ac.be>,
	"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethernet api: Document rte_eth_vmdq_rx_conf
Date: Fri, 30 Jun 2017 14:42:06 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23ED1C3B1@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <20170511082800.17608-1-tom.barbette@ulg.ac.be>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tom Barbette
> Sent: Thursday, May 11, 2017 9:28 AM
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; Tom Barbette <tom.barbette@ulg.ac.be>
> Subject: [dpdk-dev] [PATCH] ethernet api: Document rte_eth_vmdq_rx_conf
> 
> From documentation it is very unclear how VMDq configuration can be
> tweaked, and online search offer very poor results.
> 
> This patch will ultimately spawn an online documentation page for the
> rte_eth_vmdq_rx_conf struct which will eventually add a bit of
> documentation about the rx_mode tag and how to allow e.g. VMDq pools to
> receive packets without VLAN tags.

Hi Tom,

Thanks for the. The doc looks good but you need to add a signoff to the
message body:

http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body

John

      parent reply	other threads:[~2017-06-30 14:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11  8:28 Tom Barbette
2017-06-08 20:48 ` Thomas Monjalon
2017-06-30 14:42 ` Mcnamara, John [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE23ED1C3B1@IRSMSX104.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=tom.barbette@ulg.ac.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).