From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, "Hu, Jiayu" <jiayu.hu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: update programmer's guide for the GRO library
Date: Thu, 3 Aug 2017 14:41:50 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23ED596F1@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <2397072.0Y9CZzOPcT@xps>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Friday, July 21, 2017 4:09 PM
> To: Hu, Jiayu <jiayu.hu@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: update programmer's guide for the GRO
> library
>
> 11/07/2017 06:27, Jiayu Hu:
> > Add description to programmer's guide to explain the design of the GRO
> > library.
> >
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> > ---
> > MAINTAINERS | 1 +
> > .../prog_guide/generic_receive_offload_lib.rst | 163
> +++++++++++++++++++++
> > doc/guides/prog_guide/index.rst | 1 +
> > doc/guides/prog_guide/source_org.rst | 1 +
> > 4 files changed, 166 insertions(+)
> > create mode 100644
> > doc/guides/prog_guide/generic_receive_offload_lib.rst
>
> Looking for a reviewer of this new doc. Any volunteer?
I'll review and reply to Jiayu directly.
> > --- a/doc/guides/prog_guide/source_org.rst
> > +++ b/doc/guides/prog_guide/source_org.rst
> > @@ -68,6 +68,7 @@ The lib directory contains::
> > +-- librte_distributor # Packet distributor
> > +-- librte_eal # Environment abstraction layer
> > +-- librte_ether # Generic interface to poll mode driver
> > + +-- librte_gro # Generic receive offload library
> > +-- librte_hash # Hash library
> > +-- librte_ip_frag # IP fragmentation library
> > +-- librte_kni # Kernel NIC interface
>
> I really want we remove this file.
> It is useless and not well maintained.
Agreed. It is guaranteed to be out of date. It could be replaced with a much
shorter and more generic description of the main source dirs without
mentioning any of the sub-folders or files.
John
next prev parent reply other threads:[~2017-08-03 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 3:27 Jiayu Hu
2017-07-21 15:09 ` Thomas Monjalon
2017-08-03 14:41 ` Mcnamara, John [this message]
2017-08-04 0:50 ` Hu, Jiayu
2017-08-04 8:20 ` [dpdk-dev] [PATCH v2] doc: add prog_guide " Jiayu Hu
2017-08-04 9:11 ` Mcnamara, John
2017-08-04 9:37 ` Jiayu Hu
2017-08-04 9:59 ` [dpdk-dev] [PATCH v3] " Jiayu Hu
2017-08-06 12:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE23ED596F1@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).