From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eventdev: fix missing includes
Date: Fri, 4 Aug 2017 12:32:09 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23ED5AB7B@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20170804102035.4051-1-thomas@monjalon.net>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Friday, August 4, 2017 11:21 AM
> To: jerin.jacob@caviumnetworks.com
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] eventdev: fix missing includes
>
> The PCI helper file depends on some EAL definitions.
> Spotted with devtools/check-includes.sh:
> error: implicit declaration of function ‘rte_eal_process_type’
> error: ‘RTE_PROC_PRIMARY’ undeclared
> error: implicit declaration of function ‘rte_socket_id’
>
> There was also this error because the inline keyword was missing:
> error: ‘rte_event_pmd_pci_probe’ defined but not used
>
> Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions
> optional")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Spotted with devtools/check-includes.sh:
That is a good reminder for people to add this to their patch workflow or to some automated tests.
Acked-by: John McNamara <john.mcnamara@intel.com>
next prev parent reply other threads:[~2017-08-04 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 10:20 Thomas Monjalon
2017-08-04 10:35 ` Jerin Jacob
2017-08-04 10:44 ` Thomas Monjalon
2017-08-04 10:47 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2017-08-04 12:32 ` Mcnamara, John [this message]
2017-08-04 23:18 ` [dpdk-dev] [PATCH] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE23ED5AB7B@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).