From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Ravi Kumar <ravi1.kumar@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 3/4] doc: Add documents for AMD XGBE Ethernet
Date: Mon, 18 Sep 2017 17:39:11 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23EDA9ACC@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1505324838-25734-3-git-send-email-ravi1.kumar@amd.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kumar
> Sent: Wednesday, September 13, 2017 6:47 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 3/4] doc: Add documents for AMD XGBE Ethernet
>
> Signed-off-by: Ravi Kumar <ravi1.kumar@amd.com>
Thanks for the doc. Some comments below.
> ...
> +.. Copyright (c) 2017 Advanced Micro Devices, Inc.
> + All rights reserved.
> +
> + AMD 10Gb Ethernet driver
> +
> + This file is available to you under your choice of the following two
> + licenses:
> +
> + License 1: GPLv2
The docs probably don't need to be dual licensed.
> +
> +- Jumbo Frame upto 9K
s/upto/up to/
> +- Bind the intented AMD device to igb_uio module.
s/intented/intended/
Also, there was a whitespace warning on the patch. Trim any trailing
whitespace in the patch.
Thanks.
Reviewed-by: John McNamara <john.mcnamara@intel.com>
next prev parent reply other threads:[~2017-09-18 17:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 17:47 [dpdk-dev] [PATCH 1/4] Add AMD XGBE Ethernet config support in DPDK Ravi Kumar
2017-09-13 17:47 ` [dpdk-dev] [PATCH 2/4] net/axgbe : Add PMD support for AMD XGBE Ethernet Ravi Kumar
2017-09-14 16:25 ` Ferruh Yigit
2017-09-15 12:29 ` Kumar, Ravi1
2017-09-13 17:47 ` [dpdk-dev] [PATCH 3/4] doc: Add documents " Ravi Kumar
2017-09-14 11:57 ` Hemant Agrawal
2017-09-14 14:02 ` Kumar, Ravi1
2017-09-15 4:41 ` Hemant Agrawal
2017-09-15 12:26 ` Kumar, Ravi1
2017-11-13 19:20 ` Thomas Monjalon
2017-11-14 6:36 ` Kumar, Ravi1
[not found] ` <DM2PR12MB0138AA6F2C7782A949E2521C9D280@DM2PR12MB0138.namprd12.prod.outlook.com>
2017-11-15 0:07 ` Hemant Agrawal
2017-11-17 17:48 ` Shippen, Greg
2017-11-19 16:09 ` Hemant Agrawal
2017-09-14 16:26 ` Ferruh Yigit
2017-09-18 17:39 ` Mcnamara, John [this message]
2017-09-13 17:47 ` [dpdk-dev] [PATCH 4/4] maintainers: add maintainer for AMD AXGBE PMD Ravi Kumar
2017-09-14 16:26 ` Ferruh Yigit
2017-09-14 8:53 ` [dpdk-dev] [PATCH 1/4] Add AMD XGBE Ethernet config support in DPDK Ferruh Yigit
2017-09-14 9:48 ` Kumar, Ravi1
2017-09-14 16:25 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE23EDA9ACC@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=ravi1.kumar@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).