From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "techboard@dpdk.org" <techboard@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: update contribution guideline for dependent work
Date: Mon, 11 Dec 2017 14:26:34 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23EE1FE26@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20171121195905.66410-1-ferruh.yigit@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, November 21, 2017 7:59 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Mcnamara, John
> <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
> techboard@dpdk.org
> Subject: [PATCH] doc: update contribution guideline for dependent work
>
> Changing some part of the libraries but not updating all dependent code
> cause maintenance problems.
>
> ...
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
integration testing.
>
> +* If changes effect other parts of the project, update all those parts as
> well unless updating requires special knowledge.
> + For the cases not all effected code updated, ensure that changes don't
> break existing code.
> +
> * Add tests to the the ``app/test`` unit test framework where possible.
>
> * Add documentation, if relevant, in the form of Doxygen comments or a
> User Guide in RST format.
Second line would be better as:
For the cases where not all the effected code is updated, the submitter should ensure that changes don't break existing code.
Acked-by: John McNamara <john.mcnamara@intel.com>
next prev parent reply other threads:[~2017-12-11 14:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 19:59 Ferruh Yigit
2017-12-11 14:26 ` Mcnamara, John [this message]
2017-12-12 15:54 ` [dpdk-dev] [dpdk-techboard] " Olivier MATZ
2017-12-12 18:57 ` Ferruh Yigit
2017-12-13 8:55 ` Olivier MATZ
2018-01-09 15:44 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-05-24 16:58 ` Thomas Monjalon
2019-04-05 15:00 ` Ferruh Yigit
2019-04-05 15:00 ` Ferruh Yigit
2019-04-05 15:02 ` [dpdk-dev] [dpdk-techboard] " Ferruh Yigit
2019-04-05 15:02 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE23EE1FE26@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).