DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
	"Varghese, Vipin" <vipin.varghese@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>
Cc: "Varghese, Vipin" <vipin.varghese@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: update info on multi crypto instances
Date: Tue, 6 Feb 2018 12:04:47 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23EEA8680@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC935BD@IRSMSX108.ger.corp.intel.com>



> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Monday, February 5, 2018 3:58 PM
> To: Varghese, Vipin <vipin.varghese@intel.com>; dev@dpdk.org; Kovacevic,
> Marko <marko.kovacevic@intel.com>
> Cc: Mcnamara, John <john.mcnamara@intel.com>; Varghese, Vipin
> <vipin.varghese@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] doc: update info on multi crypto instances
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vipin Varghese
> > Sent: Monday, February 5, 2018 2:36 PM
> > To: dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>
> > Cc: Mcnamara, John <john.mcnamara@intel.com>; Varghese, Vipin
> > <vipin.varghese@intel.com>
> > Subject: [dpdk-dev] [PATCH] doc: update info on multi crypto instances
> >
> > Added note section to update information for use cases working with
> > multiple crypto devices.
> 
> I would change the title to something more generic, since you are adding
> other info and not just the multi crypto device issue.
> 
> >
> > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > ---
> >  doc/guides/sample_app_ug/l2_forward_crypto.rst | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/doc/guides/sample_app_ug/l2_forward_crypto.rst
> > b/doc/guides/sample_app_ug/l2_forward_crypto.rst
> > index 1e85b4a..c2e6128 100644
> > --- a/doc/guides/sample_app_ug/l2_forward_crypto.rst
> > +++ b/doc/guides/sample_app_ug/l2_forward_crypto.rst
> > @@ -199,6 +199,14 @@ To run the application in linuxapp environment
> > with 2 lcores, 2 ports and 2 cryp  Refer to the *DPDK Getting Started
> > Guide* for general information on running applications  and the
> > Environment Abstraction Layer (EAL) options.
> >
> > +.. Note::
> > +
> > +    * The ``l2fwd-crypto`` sample application requires IPv4 packets
> > + for
> > crypto operation.
> > +
> > +    * If multiple Ethernet ports is passed, then equal number of
> > +      crypto devices are to be passed.

Probably better as:

   If multiple Ethernet ports are passed then an equal number of
   crypto devices must be passed.

  reply	other threads:[~2018-02-06 12:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 14:35 Vipin Varghese
2018-02-05 15:58 ` De Lara Guarch, Pablo
2018-02-06 12:04   ` Mcnamara, John [this message]
2018-02-05 17:32 ` [dpdk-dev] [PATCH v2] doc: update application minimum requirement info Vipin Varghese
2018-02-06 12:00   ` Mcnamara, John
2018-02-06 16:35   ` De Lara Guarch, Pablo
2018-02-06 21:28     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE23EEA8680@IRSMSX103.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=dev@dpdk.org \
    --cc=marko.kovacevic@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).