From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Minor C++11 compilation fix for rte_pci.h
Date: Fri, 13 Feb 2015 10:27:33 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2EC22A5@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20150213101732.GA13304@bricha3-MOBL3>
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Friday, February 13, 2015 10:18 AM
> To: Mcnamara, John
> Cc: Stefan Puiu; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] Minor C++11 compilation fix for rte_pci.h
>
> > >
> > > In C++11 concatenated string literals need to have a space in between.
> > > clang 3.4 reports this as an error (and IIRC also gcc-4.8):
> > >
> > > dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal;
> > > C++11 requires a space between literal and identifier
> > > [-Wreserved-user-defined- literal]
> >
> >
> > That concatenated string literal with PRI* is used in 65 files in the
> DPDK source. Is that the only compilation error that you got?
> >
> > John
>
> It should only be a problem in header files. The C files for DPDK source
> are always to be compiled up with a C compiler - only the headers get
> included in application C++ code.
>
Hi,
In that case it only occurs in 3 header files. I guess that patch should be extended to include those as well:
$ find lib -name \*.h | xargs grep -l '"PRI'
lib/librte_vhost/vhost-net-cdev.h
lib/librte_eal/common/include/rte_pci.h
lib/librte_mempool/rte_mempool.h
John.
--
next prev parent reply other threads:[~2015-02-13 10:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 8:50 Stefan Puiu
2015-02-13 8:25 ` Mcnamara, John
2015-02-13 10:17 ` Bruce Richardson
2015-02-13 10:27 ` Mcnamara, John [this message]
2015-02-20 12:26 ` Stefan Puiu
2015-02-20 13:18 ` [dpdk-dev] [PATCH 1/2] rte_pci.h: Fix C++11 compilation Stefan Puiu
2015-02-20 13:23 ` Stefan Puiu
2015-02-20 13:23 ` [dpdk-dev] [PATCH 2/2] Headers: more C++11 compilation fixes Stefan Puiu
2015-02-24 1:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2EC22A5@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).