From: "Wang, Liang-min" <liang-min.wang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples: new example: l2fwd-ethtool
Date: Wed, 21 Oct 2015 16:46:49 +0000 [thread overview]
Message-ID: <B6CB929FEBC10D4FAC4BCA7EF2298E2579012326@FMSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <2579237.5XQrXtFRuP@xps13>
Thomas,
Let's put this patch on defer list because there are related work might take a different approach. Let's only review the make file change (PATCH 1/2). I believe "export" is needed since the variable is shared by all the build but it might be already included due to the mk file inclusion. Since Andy is on vacation, I am not sure if he could make a comment on that.
Larry
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, October 21, 2015 12:36 PM
> To: Wang, Liang-min
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples: new example: l2fwd-
> ethtool
>
> 2015-07-23 11:00, Liang-Min Larry Wang:
> > examples/Makefile | 1 +
> > examples/l2fwd-ethtool/Makefile | 48 +
> > examples/l2fwd-ethtool/l2fwd-app/Makefile | 58 ++
> > examples/l2fwd-ethtool/l2fwd-app/main.c | 1025
> ++++++++++++++++++++++
> > examples/l2fwd-ethtool/l2fwd-app/netdev_api.h | 770
> ++++++++++++++++
> > examples/l2fwd-ethtool/l2fwd-app/shared_fifo.h | 159 ++++
> > examples/l2fwd-ethtool/lib/Makefile | 57 ++
> > examples/l2fwd-ethtool/lib/rte_ethtool.c | 336 +++++++
> > examples/l2fwd-ethtool/lib/rte_ethtool.h | 385 ++++++++
> > examples/l2fwd-ethtool/nic-control/Makefile | 55 ++
> > examples/l2fwd-ethtool/nic-control/nic_control.c | 614 +++++++++++++
> > 11 files changed, 3508 insertions(+)
>
> This patch is huge.
> Please split a bit.
>
> > --- a/examples/Makefile
> > +++ b/examples/Makefile
> > @@ -53,6 +53,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_KNI) += kni
> > DIRS-y += l2fwd
> > DIRS-$(CONFIG_RTE_LIBRTE_IVSHMEM) += l2fwd-ivshmem
> > DIRS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += l2fwd-jobstats
> > +DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += l2fwd-ethtool
> > DIRS-y += l3fwd
>
> Please keep the alphabetical order.
>
> I do not plan to review it more.
> If nobody complains, it means it's accepted.
next prev parent reply other threads:[~2015-10-21 16:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 14:12 [dpdk-dev] [PATCH] User-space Ethool example Liang-Min Larry Wang
2015-07-20 14:12 ` [dpdk-dev] [PATCH] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-23 15:00 ` [dpdk-dev] [PATCH v2 0/2] Example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-23 15:00 ` [dpdk-dev] [PATCH v2 1/2] Remove ABI requierment for external library builds Liang-Min Larry Wang
2015-10-21 16:31 ` Thomas Monjalon
2015-07-23 15:00 ` [dpdk-dev] [PATCH v2 2/2] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-10-21 16:36 ` Thomas Monjalon
2015-10-21 16:46 ` Wang, Liang-min [this message]
2015-11-17 22:33 ` Wang, Liang-min
2015-11-18 17:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B6CB929FEBC10D4FAC4BCA7EF2298E2579012326@FMSMSX113.amr.corp.intel.com \
--to=liang-min.wang@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).