From: "Wang, Xiao W" <xiao.w.wang@intel.com>
To: "Chen, Jing D" <jing.d.chen@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] fm10k: fix wrong Rx func is used
Date: Fri, 27 Nov 2015 05:38:13 +0000 [thread overview]
Message-ID: <B7F2E978279D1D49A3034B7786DACF403C83DC79@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1448589345-16239-1-git-send-email-jing.d.chen@intel.com>
Hi,
> -----Original Message-----
> From: Chen, Jing D
> Sent: Friday, November 27, 2015 9:56 AM
> To: dev@dpdk.org
> Cc: Wang, Xiao W <xiao.w.wang@intel.com>; Chen, Jing D
> <jing.d.chen@intel.com>
> Subject: [PATCH] fm10k: fix wrong Rx func is used
>
> From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
>
> Steps to reproduce the bug:
> 1. All Rx offloading is disabled and start the device, then
> Vector Rx is used.
> 2. Stop the device. Re-configure to enable hw_ip_checksum = 1,
> start the device again.
> 3. In this case, assume regular Rx should be used since Vector
> Rx doesn't support ip checksum offload. But actually Vector
> Rx is used and cause checksum won't be done by hardware.
>
> The reason is after re-configuring, driver misses an "else" in func
> fm10k_set_rx_function(). Then Rx func in last round are used.
>
> Fixes:77a8ab47("fm10k: select best Rx function")
>
> Reported-by: Xiao Wang <xiao.w.wang@intel.com>
> Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
> ---
> drivers/net/fm10k/fm10k_ethdev.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/fm10k/fm10k_ethdev.c
> b/drivers/net/fm10k/fm10k_ethdev.c
> index 4f23ce3..e4aed94 100644
> --- a/drivers/net/fm10k/fm10k_ethdev.c
> +++ b/drivers/net/fm10k/fm10k_ethdev.c
> @@ -2486,6 +2486,8 @@ fm10k_set_rx_function(struct rte_eth_dev *dev)
> dev->rx_pkt_burst = fm10k_recv_pkts_vec;
> } else if (dev->data->scattered_rx)
> dev->rx_pkt_burst = fm10k_recv_scattered_pkts;
> + else
> + dev->rx_pkt_burst = fm10k_recv_pkts;
>
> rx_using_sse =
> (dev->rx_pkt_burst == fm10k_recv_scattered_pkts_vec ||
> --
> 1.7.7.6
Acked-by: Xiao Wang <xiao.w.wang@intel.com>
next prev parent reply other threads:[~2015-11-27 5:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 1:55 Chen Jing D(Mark)
2015-11-27 5:38 ` Wang, Xiao W [this message]
2015-11-27 18:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B7F2E978279D1D49A3034B7786DACF403C83DC79@SHSMSX101.ccr.corp.intel.com \
--to=xiao.w.wang@intel.com \
--cc=dev@dpdk.org \
--cc=jing.d.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).