From: "Wang, Xiao W" <xiao.w.wang@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>,
"Chen, Jing D" <jing.d.chen@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/5] net/fm10k: add back Rx checksum offload
Date: Wed, 31 Aug 2016 09:02:18 +0000 [thread overview]
Message-ID: <B7F2E978279D1D49A3034B7786DACF406C181937@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1d4aec4b-8f58-8739-c21f-04b09ecca05a@6wind.com>
Hi Olivier,
> -----Original Message-----
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> Sent: Friday, August 26, 2016 3:27 PM
> To: Wang, Xiao W <xiao.w.wang@intel.com>; Chen, Jing D
> <jing.d.chen@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH 1/5] net/fm10k: add back Rx checksum offload
>
> Hi Xiao,
>
> On 08/25/2016 07:48 PM, Xiao Wang wrote:
> > A previous patch (http://dpdk.org/dev/patchwork/patch/12937/) removed
> > some necessary lines about Rx checksum by mistake, this patch adds
> > them back.
> >
> > Fixes: 6046898f5097 ("net/mbuf: remove unused Rx error flags")
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
>
> Just a small comment about the title, what do you thinkg about:
> "net/fm10k: fix Rx checksum flags" ?
> I think having the word "fix" in the title would help for finding these
> commits for the stable version.
>
> Apart from that, thanks for fixing my mistake :)
>
>
> Regards,
> Olivier
I agree with you, will change the commit log in V2.
Best Regards,
Xiao
next prev parent reply other threads:[~2016-08-31 9:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 17:48 [dpdk-dev] [PATCH 0/5] implement new Rx checksum flag Xiao Wang
2016-08-25 17:48 ` [dpdk-dev] [PATCH 1/5] net/fm10k: add back Rx checksum offload Xiao Wang
2016-08-26 7:27 ` Olivier Matz
2016-08-31 9:02 ` Wang, Xiao W [this message]
2016-08-25 17:48 ` [dpdk-dev] [PATCH 2/5] net/fm10k: implement new Rx checksum flag Xiao Wang
2016-08-29 9:32 ` Chen, Jing D
2016-08-31 8:59 ` Wang, Xiao W
2016-08-25 17:48 ` [dpdk-dev] [PATCH 3/5] net/e1000: " Xiao Wang
2016-08-25 17:48 ` [dpdk-dev] [PATCH 4/5] net/ixgbe: " Xiao Wang
2016-08-26 7:30 ` Olivier Matz
2016-08-31 9:07 ` Wang, Xiao W
2016-08-25 17:48 ` [dpdk-dev] [PATCH 5/5] net/i40e: " Xiao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B7F2E978279D1D49A3034B7786DACF406C181937@SHSMSX101.ccr.corp.intel.com \
--to=xiao.w.wang@intel.com \
--cc=dev@dpdk.org \
--cc=jing.d.chen@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).