From: "Wang, Xiao W" <xiao.w.wang@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 08/15] net/ifc: rename to ifcvf
Date: Wed, 13 Jun 2018 02:46:05 +0000 [thread overview]
Message-ID: <B7F2E978279D1D49A3034B7786DACF406F92FD12@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20180608212048.67261-9-bruce.richardson@intel.com>
Hi Bruce,
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Saturday, June 9, 2018 5:21 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Wang, Xiao W
> <xiao.w.wang@intel.com>
> Subject: [PATCH v2 08/15] net/ifc: rename to ifcvf
>
> All files in the directory and the resulting driver have prefix of ifcvf,
> not just ifc, so rename directory for accuracy. Also rename the map file
> to standard name for meson build in the process.
Compared with renaming the dir to IFCVF and renaming it back to IFC sometime in future,
I think keeping the dir name as IFC is better for us, this avoids the extra effort.
We can just rename below files:
doc/guides/nics/ifcvf.rst => doc/guides/nics/ifc.rst
drivers/net/ifc/rte_ifcvf_version.map => drivers/net/ifc/rte_pmd_ifc_version.
And yes, we need to update documents which refer to ifc.
Thanks!
Xiao
>
> CC: Xiao Wang <xiao.w.wang@intel.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> MAINTAINERS | 4 ++--
> drivers/net/Makefile | 2 +-
> drivers/net/{ifc => ifcvf}/Makefile | 2 +-
> drivers/net/{ifc => ifcvf}/base/ifcvf.c | 0
> drivers/net/{ifc => ifcvf}/base/ifcvf.h | 0
> drivers/net/{ifc => ifcvf}/base/ifcvf_osdep.h | 0
> drivers/net/{ifc => ifcvf}/ifcvf_vdpa.c | 0
> .../rte_ifcvf_version.map => ifcvf/rte_pmd_ifcvf_version.map} | 0
> 8 files changed, 4 insertions(+), 4 deletions(-)
> rename drivers/net/{ifc => ifcvf}/Makefile (94%)
> rename drivers/net/{ifc => ifcvf}/base/ifcvf.c (100%)
> rename drivers/net/{ifc => ifcvf}/base/ifcvf.h (100%)
> rename drivers/net/{ifc => ifcvf}/base/ifcvf_osdep.h (100%)
> rename drivers/net/{ifc => ifcvf}/ifcvf_vdpa.c (100%)
> rename drivers/net/{ifc/rte_ifcvf_version.map =>
> ifcvf/rte_pmd_ifcvf_version.map} (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4667fa7fb..4f6055590 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -559,10 +559,10 @@ T: git://dpdk.org/next/dpdk-next-net-intel
> F: drivers/net/avf/
> F: doc/guides/nics/features/avf*.ini
>
> -Intel ifc
> +Intel ifcvf
> M: Xiao Wang <xiao.w.wang@intel.com>
> T: git://dpdk.org/next/dpdk-next-net-intel
> -F: drivers/net/ifc/
> +F: drivers/net/ifcvf/
> F: doc/guides/nics/ifcvf.rst
> F: doc/guides/nics/features/ifcvf.ini
>
> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
> index 9f9da6651..9308f9a7b 100644
> --- a/drivers/net/Makefile
> +++ b/drivers/net/Makefile
> @@ -59,7 +59,7 @@ endif # $(CONFIG_RTE_LIBRTE_SCHED)
> ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y)
> DIRS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += vhost
> ifeq ($(CONFIG_RTE_EAL_VFIO),y)
> -DIRS-$(CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD) += ifc
> +DIRS-$(CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD) += ifcvf
> endif
> endif # $(CONFIG_RTE_LIBRTE_VHOST)
>
> diff --git a/drivers/net/ifc/Makefile b/drivers/net/ifcvf/Makefile
> similarity index 94%
> rename from drivers/net/ifc/Makefile
> rename to drivers/net/ifcvf/Makefile
> index 1011995bc..a022faaad 100644
> --- a/drivers/net/ifc/Makefile
> +++ b/drivers/net/ifcvf/Makefile
> @@ -22,7 +22,7 @@ BASE_DRIVER_OBJS=$(sort $(patsubst %.c,%.o,$(notdir
> $(wildcard $(SRCDIR)/base/*.
>
> VPATH += $(SRCDIR)/base
>
> -EXPORT_MAP := rte_ifcvf_version.map
> +EXPORT_MAP := rte_pmd_ifcvf_version.map
>
> LIBABIVER := 1
>
> diff --git a/drivers/net/ifc/base/ifcvf.c b/drivers/net/ifcvf/base/ifcvf.c
> similarity index 100%
> rename from drivers/net/ifc/base/ifcvf.c
> rename to drivers/net/ifcvf/base/ifcvf.c
> diff --git a/drivers/net/ifc/base/ifcvf.h b/drivers/net/ifcvf/base/ifcvf.h
> similarity index 100%
> rename from drivers/net/ifc/base/ifcvf.h
> rename to drivers/net/ifcvf/base/ifcvf.h
> diff --git a/drivers/net/ifc/base/ifcvf_osdep.h
> b/drivers/net/ifcvf/base/ifcvf_osdep.h
> similarity index 100%
> rename from drivers/net/ifc/base/ifcvf_osdep.h
> rename to drivers/net/ifcvf/base/ifcvf_osdep.h
> diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifcvf/ifcvf_vdpa.c
> similarity index 100%
> rename from drivers/net/ifc/ifcvf_vdpa.c
> rename to drivers/net/ifcvf/ifcvf_vdpa.c
> diff --git a/drivers/net/ifc/rte_ifcvf_version.map
> b/drivers/net/ifcvf/rte_pmd_ifcvf_version.map
> similarity index 100%
> rename from drivers/net/ifc/rte_ifcvf_version.map
> rename to drivers/net/ifcvf/rte_pmd_ifcvf_version.map
> --
> 2.17.1
next prev parent reply other threads:[~2018-06-13 2:46 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 20:15 [dpdk-dev] [PATCH-18.08 00/15] add meson support for more net drivers Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 01/15] net/ark: add to meson build Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 02/15] net/avp: " Bruce Richardson
2018-05-18 11:13 ` Legacy, Allain
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 03/15] net/bnx2x: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 04/15] net/bnxt: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 05/15] net/cxgbe: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 06/15] net/ena: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 07/15] net/failsafe: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 08/15] net/ifc: rename to ifcvf Bruce Richardson
2018-05-18 1:52 ` Wang, Xiao W
2018-05-18 8:12 ` Bruce Richardson
2018-05-18 16:37 ` Wang, Xiao W
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 09/15] net/ifcvf: add to meson build Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 10/15] net/kni: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 11/15] net/liquidio: " Bruce Richardson
2018-05-21 8:47 ` Shijith Thotton
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 12/15] net/nfp: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 13/15] net/softnic: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 14/15] net/szedata2: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 15/15] net/vhost: " Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 00/15] add meson support for more net drivers Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 01/15] net/ark: add to meson build Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 02/15] net/avp: " Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 03/15] net/bnx2x: " Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 04/15] net/bnxt: " Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 05/15] net/cxgbe: " Bruce Richardson
2018-06-14 14:55 ` Ferruh Yigit
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 06/15] net/ena: " Bruce Richardson
2018-06-14 14:55 ` Ferruh Yigit
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 07/15] net/failsafe: " Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 08/15] net/ifc: rename to ifcvf Bruce Richardson
2018-06-13 2:46 ` Wang, Xiao W [this message]
2018-06-13 10:19 ` Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 09/15] net/ifcvf: add to meson build Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 10/15] net/kni: " Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 11/15] net/liquidio: " Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 12/15] net/nfp: " Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 13/15] net/softnic: " Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 14/15] net/szedata2: " Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 15/15] net/vhost: " Bruce Richardson
2018-06-14 14:55 ` [dpdk-dev] [PATCH v2 00/15] add meson support for more net drivers Ferruh Yigit
2018-06-14 16:25 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B7F2E978279D1D49A3034B7786DACF406F92FD12@SHSMSX101.ccr.corp.intel.com \
--to=xiao.w.wang@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).