From: "Wang, Xiao W" <xiao.w.wang@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 05/11] net/fm10k: fix Tx prepare to set positive rte_errno
Date: Mon, 10 Jun 2019 02:05:17 +0000 [thread overview]
Message-ID: <B7F2E978279D1D49A3034B7786DACF407AF37D4E@SHSMSX106.ccr.corp.intel.com> (raw)
In-Reply-To: <1559722565-25992-6-git-send-email-arybchenko@solarflare.com>
Hi,
> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
> Sent: Wednesday, June 5, 2019 4:16 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W
> <xiao.w.wang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH 05/11] net/fm10k: fix Tx prepare to set positive rte_errno
>
> Fixes: 9b134aa39716 ("net/fm10k: add Tx preparation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> drivers/net/fm10k/fm10k_rxtx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c
> index cc95f95..2f4dad0 100644
> --- a/drivers/net/fm10k/fm10k_rxtx.c
> +++ b/drivers/net/fm10k/fm10k_rxtx.c
> @@ -698,25 +698,25 @@ static inline void tx_xmit_pkt(struct
> fm10k_tx_queue *q, struct rte_mbuf *mb)
>
> if ((m->ol_flags & PKT_TX_TCP_SEG) &&
> (m->tso_segsz < FM10K_TSO_MINMSS)) {
> - rte_errno = -EINVAL;
> + rte_errno = EINVAL;
> return i;
> }
>
> if (m->ol_flags & FM10K_TX_OFFLOAD_NOTSUP_MASK) {
> - rte_errno = -ENOTSUP;
> + rte_errno = ENOTSUP;
> return i;
> }
>
> #ifdef RTE_LIBRTE_ETHDEV_DEBUG
> ret = rte_validate_tx_offload(m);
> if (ret != 0) {
> - rte_errno = ret;
> + rte_errno = -ret;
> return i;
> }
> #endif
> ret = rte_net_intel_cksum_prepare(m);
> if (ret != 0) {
> - rte_errno = ret;
> + rte_errno = -ret;
> return i;
> }
> }
> --
> 1.8.3.1
Acked-by: Xiao Wang <xiao.w.wang@intel.com>
next prev parent reply other threads:[~2019-06-10 2:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1559722565-25992-1-git-send-email-arybchenko@solarflare.com>
2019-06-05 8:15 ` [dpdk-stable] [PATCH 01/11] ethdev: fix Tx prepare documentation to use positive errno Andrew Rybchenko
2019-06-05 8:15 ` [dpdk-stable] [PATCH 02/11] net/atlantic: fix Tx prepare to set positive rte_errno Andrew Rybchenko
2019-06-05 8:15 ` [dpdk-stable] [PATCH 03/11] net/e1000: " Andrew Rybchenko
2019-06-05 8:15 ` [dpdk-stable] [PATCH 04/11] net/enic: " Andrew Rybchenko
2019-06-05 8:15 ` [dpdk-stable] [PATCH 05/11] net/fm10k: " Andrew Rybchenko
2019-06-10 2:05 ` Wang, Xiao W [this message]
2019-06-05 8:15 ` [dpdk-stable] [PATCH 06/11] net/i40e: " Andrew Rybchenko
2019-06-05 8:16 ` [dpdk-stable] [PATCH 07/11] net/iavf: " Andrew Rybchenko
2019-06-05 8:16 ` [dpdk-stable] [PATCH 08/11] net/ice: " Andrew Rybchenko
2019-06-05 8:16 ` [dpdk-stable] [PATCH 09/11] net/ixgbe: " Andrew Rybchenko
2019-06-05 8:16 ` [dpdk-stable] [PATCH 10/11] net/qede: " Andrew Rybchenko
2019-06-05 8:16 ` [dpdk-stable] [PATCH 11/11] net/vmxnet3: " Andrew Rybchenko
2019-06-05 22:45 ` Yong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B7F2E978279D1D49A3034B7786DACF407AF37D4E@SHSMSX106.ccr.corp.intel.com \
--to=xiao.w.wang@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).