From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Zhang, Helin" <helin.zhang@intel.com>,
"damarion@cisco.com" <damarion@cisco.com>,
"Kinsella, Ray" <ray.kinsella@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd
Date: Sat, 29 Sep 2018 01:57:24 +0000 [thread overview]
Message-ID: <B9E724F4CB7543449049E7AE7669D82F657B6F@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <CAOaVG15Z-M7gh10-2=jz-uz2Yyop_QXcOA299n6gW=wR7ZtM_Q@mail.gmail.com>
Sure. Anyway there is an error log to indicate the error.
I will send v3 later. Thanks.
From: Stephen Hemminger [mailto:stephen@networkplumber.org]
Sent: Friday, September 28, 2018 20:47
To: Li, Xiaoyun <xiaoyun.li@intel.com>
Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Zhang, Helin <helin.zhang@intel.com>; damarion@cisco.com; Kinsella, Ray <ray.kinsella@intel.com>; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd
In general, an API is less error prone if it only does return by value. What about just returning fd or -1?
On Fri, Sep 28, 2018, 5:55 AM Xiaoyun Li <xiaoyun.li@intel.com<mailto:xiaoyun.li@intel.com>> wrote:
Some users want to use their own epoll instances to control both
DPDK rxq interrupt fds and their own other fds. So added a function
to get rxq interrupt fd based on port id and queue id.
Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com<mailto:xiaoyun.li@intel.com>>
---
lib/librte_ethdev/rte_ethdev.c | 37 ++++++++++++++++++++++++++++++++++
lib/librte_ethdev/rte_ethdev.h | 3 +++
2 files changed, 40 insertions(+)
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index ef99f7068..c21124e32 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -3433,6 +3433,43 @@ rte_eth_dev_rx_intr_ctl(uint16_t port_id, int epfd, int op, void *data)
return 0;
}
+int
+rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, uint16_t queue_id,
+ int *fd)
+{
+ struct rte_intr_handle *intr_handle;
+ struct rte_eth_dev *dev;
+ unsigned int efd_idx;
+ uint32_t vec;
+
+ RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+ dev = &rte_eth_devices[port_id];
+
+ if (queue_id >= dev->data->nb_rx_queues) {
+ RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n", queue_id);
+ return -EINVAL;
+ }
+
+ if (!dev->intr_handle) {
+ RTE_ETHDEV_LOG(ERR, "RX Intr handle unset\n");
+ return -ENOTSUP;
+ }
+
+ intr_handle = dev->intr_handle;
+ if (!intr_handle->intr_vec) {
+ RTE_ETHDEV_LOG(ERR, "RX Intr vector unset\n");
+ return -EPERM;
+ }
+
+ vec = intr_handle->intr_vec[queue_id];
+ efd_idx = (vec >= RTE_INTR_VEC_RXTX_OFFSET) ?
+ (vec - RTE_INTR_VEC_RXTX_OFFSET) : vec;
+ *fd = intr_handle->efds[efd_idx];
+
+ return 0;
+}
+
const struct rte_memzone *
rte_eth_dma_zone_reserve(const struct rte_eth_dev *dev, const char *ring_name,
uint16_t queue_id, size_t size, unsigned align,
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 012577b0a..3670d7249 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -2719,6 +2719,9 @@ int rte_eth_dev_rx_intr_ctl(uint16_t port_id, int epfd, int op, void *data);
int rte_eth_dev_rx_intr_ctl_q(uint16_t port_id, uint16_t queue_id,
int epfd, int op, void *data);
+int rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, uint16_t queue_id,
+ int *fd);
+
/**
* Turn on the LED on the Ethernet device.
* This function turns on the LED on the Ethernet device.
--
2.17.1
next prev parent reply other threads:[~2018-09-29 1:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 3:43 Xiaoyun Li
2018-09-28 8:33 ` Ferruh Yigit
2018-09-28 9:08 ` Li, Xiaoyun
2018-09-28 10:05 ` [dpdk-dev] [PATCH v2] " Xiaoyun Li
2018-09-28 12:46 ` [dpdk-dev] [PATCH] " Stephen Hemminger
2018-09-29 1:57 ` Li, Xiaoyun [this message]
2018-09-29 2:12 ` [dpdk-dev] [PATCH v3] " Xiaoyun Li
2018-10-02 10:48 ` Ferruh Yigit
2018-10-04 15:31 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9E724F4CB7543449049E7AE7669D82F657B6F@SHSMSX101.ccr.corp.intel.com \
--to=xiaoyun.li@intel.com \
--cc=damarion@cisco.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=helin.zhang@intel.com \
--cc=ray.kinsella@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).