From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: select fdir config automatically
Date: Sat, 29 Sep 2018 08:40:58 +0000 [thread overview]
Message-ID: <B9E724F4CB7543449049E7AE7669D82F658362@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E013224C3C2@SHSMSX101.ccr.corp.intel.com>
> -----Original Message-----
> From: Xing, Beilei
> Sent: Saturday, September 29, 2018 16:37
> To: Li, Xiaoyun <xiaoyun.li@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2] net/i40e: select fdir config automatically
>
>
>
> > -----Original Message-----
> > From: Li, Xiaoyun
> > Sent: Friday, September 28, 2018 7:03 PM
> > To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
> > Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>
> > Subject: [PATCH v2] net/i40e: select fdir config automatically
> >
> > I40e driver needed users to config exact fdir mode to create rte_flow
> > rules but it shouldn't. This patch allows users to create rte_flow
> > rules without configuring fdir mode and let the driver select the
> > config automatically. And remove the workaround in flow_filtering
> example.
> >
> > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> > ---
> > v2:
> > * Added fdir teardown in i40e_flow_flush_fdir_filter.
> > * Replace TAILQ_FIRST with TAILQ_EMPTY which is more intuitive.
> > * Remove the workaround in flow_filtering example since the driver
> > will
> > * set the fdir config automatically.
> > +
> > + /* If the last flow is destroyed, disable fdir. */
> > + if (!ret && !TAILQ_EMPTY(&pf->fdir.fdir_list)) {
>
> Should be if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) here?
Yes. Sorry about that. Will correct it.
>
> > --
> > 2.17.1
next prev parent reply other threads:[~2018-09-29 8:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 7:24 [dpdk-dev] [PATCH] " Xiaoyun Li
2018-09-28 8:40 ` Xing, Beilei
2018-09-28 10:38 ` Li, Xiaoyun
2018-09-28 11:03 ` [dpdk-dev] [PATCH v2] " Xiaoyun Li
2018-09-29 8:36 ` Xing, Beilei
2018-09-29 8:40 ` Li, Xiaoyun [this message]
2018-09-29 8:44 ` [dpdk-dev] [PATCH v3] " Xiaoyun Li
2018-09-30 2:08 ` [dpdk-dev] [PATCH v4] net/i40e: config fdir automatically Xiaoyun Li
2018-09-30 2:29 ` [dpdk-dev] [PATCH v5] " Xiaoyun Li
2018-09-30 2:41 ` Xing, Beilei
2018-09-30 3:31 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9E724F4CB7543449049E7AE7669D82F658362@SHSMSX101.ccr.corp.intel.com \
--to=xiaoyun.li@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).