From: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
To: Aaron Conole <aconole@redhat.com>
Cc: "pbhagavatula@caviumnetworks.com"
<pbhagavatula@caviumnetworks.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore role check function
Date: Thu, 11 Jan 2018 23:09:43 +0000 [thread overview]
Message-ID: <BE54F058557D9A4FAC1D84E2FC6D87570EDA01F5@fmsmsx115.amr.corp.intel.com> (raw)
In-Reply-To: <f7ttvvv3rt4.fsf@dhcp-25.97.bos.redhat.com>
Hi Aaron,
> -----Original Message-----
> From: Aaron Conole [mailto:aconole@redhat.com]
> Sent: Tuesday, January 9, 2018 10:45 AM
> To: Carrillo, Erik G <erik.g.carrillo@intel.com>
> Cc: pbhagavatula@caviumnetworks.com; Van Haaren, Harry
> <harry.van.haaren@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore role
> check function
>
> Hi Erik,
>
> Erik Gabriel Carrillo <erik.g.carrillo@intel.com> writes:
>
> > Update rte_lcore_has_role() so that it returns true/false instead of
> > success/failure.
> >
> > Fixes: 78666372fa2b ("eal: add function to check lcore role")
> >
> > Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> > ---
>
> I believe this breaks the published abi - Success is now 'true', and failure is
> 'false'; previously success would be 0 == false. You'll need to invert the test,
> or note that the abi is breaking (since semantically any caller will need to
> invert the test).
Good point. Though it seems like an API change rather than an ABI change to me, would it still be handled the same way in terms of notice? Also, the ABI policy states, "ABI breakage due to changes such as reorganizing public structure fields for aesthetic or readability purposes should be avoided." Perhaps I should go with an alternate patch that fixes the caller.
Thanks,
Erik
next prev parent reply other threads:[~2018-01-11 23:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 18:43 [dpdk-dev] [PATCH 0/1] " Erik Gabriel Carrillo
2018-01-03 18:43 ` [dpdk-dev] [PATCH 1/1] " Erik Gabriel Carrillo
2018-01-04 8:47 ` Pavan Nikhilesh
2018-01-09 16:44 ` Aaron Conole
2018-01-11 23:09 ` Carrillo, Erik G [this message]
2018-01-11 23:17 ` Thomas Monjalon
2018-01-12 18:01 ` Carrillo, Erik G
2018-01-12 18:04 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BE54F058557D9A4FAC1D84E2FC6D87570EDA01F5@fmsmsx115.amr.corp.intel.com \
--to=erik.g.carrillo@intel.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).