From: "Jiang, Cheng1" <cheng1.jiang@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Hu, Jiayu" <jiayu.hu@intel.com>,
"Ding, Xuan" <xuan.ding@intel.com>,
"Ma, WenwuX" <wenwux.ma@intel.com>,
"Wang, YuanX" <yuanx.wang@intel.com>,
"Yang, YvonneX" <yvonnex.yang@intel.com>
Subject: RE: [RFC v3] add support for async vhost packed ring dequeue
Date: Thu, 9 Jun 2022 13:23:25 +0000 [thread overview]
Message-ID: <BL0PR11MB3187AD46CA073449BD23B0F5DCA79@BL0PR11MB3187.namprd11.prod.outlook.com> (raw)
In-Reply-To: <b7e6f37c-0cb7-ec1b-1d83-cf02d023499b@redhat.com>
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Thursday, June 9, 2022 9:04 PM
> To: Jiang, Cheng1 <cheng1.jiang@intel.com>; Xia, Chenbo
> <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Ding, Xuan
> <xuan.ding@intel.com>; Ma, WenwuX <wenwux.ma@intel.com>; Wang,
> YuanX <yuanx.wang@intel.com>; Yang, YvonneX <yvonnex.yang@intel.com>
> Subject: Re: [RFC v3] add support for async vhost packed ring dequeue
>
> Hi Cheng,
>
> On 5/30/22 06:56, Cheng Jiang wrote:
> > This RFC patch implements packed ring dequeue data path for
> > asynchronous vhost.
>
> Please remove RFC in the next revision.
Sure.
>
> > Signed-off-by: Cheng Jiang <cheng1.jiang@intel.com>
> > ---
> > lib/vhost/virtio_net.c | 217
> ++++++++++++++++++++++++++++++++++++-----
> > 1 file changed, 191 insertions(+), 26 deletions(-)
> >
> > diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
>
> ...
>
> > +
> > +static __rte_always_inline int
> > +virtio_dev_tx_async_single_packed(struct virtio_net *dev,
> > + struct vhost_virtqueue *vq,
> > + struct rte_mempool *mbuf_pool,
> > + struct rte_mbuf *pkts,
> > + uint16_t slot_idx,
> > + bool legacy_ol_flags)
> > +{
> > + int err;
> > + uint16_t buf_id, desc_count = 0;
> > + uint16_t nr_vec = 0;
> > + uint32_t buf_len;
> > + struct buf_vector buf_vec[BUF_VECTOR_MAX];
> > + static bool allocerr_warned;
> > +
> > + if (unlikely(fill_vec_buf_packed(dev, vq, vq->last_avail_idx,
> &desc_count,
> > + buf_vec, &nr_vec, &buf_id,
> &buf_len,
> > + VHOST_ACCESS_RO) < 0))
> > + return -1;
> > +
> > + if (unlikely(virtio_dev_pktmbuf_prep(dev, pkts, buf_len))) {
> > + if (!allocerr_warned) {
> > + VHOST_LOG_DATA(ERR, "Failed mbuf alloc of size %d
> from %s on %s.\n",
> > + buf_len, mbuf_pool->name, dev->ifname);
>
> We have defined a common format for all Vhost logs to ease logs
> filtering:
> VHOST_LOG_DATA(ERR, "(%s) Failed mbuf alloc of size %d from %s.\n",
>
> dev->ifname, buf_len, mbuf_pool->name);
>
> Could you please fix it here and everywhere else in the patch?
>
> With above minor comments fixed, feel free to add:
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> Thanks,
> Maxime
Sure, got it. I'll fix it.
Thanks a lot.
Cheng
prev parent reply other threads:[~2022-06-09 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 8:25 [RFC] add support for async " Cheng Jiang
2022-05-30 4:56 ` [RFC v3] add support for async vhost " Cheng Jiang
2022-06-09 13:03 ` Maxime Coquelin
2022-06-09 13:23 ` Jiang, Cheng1 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB3187AD46CA073449BD23B0F5DCA79@BL0PR11MB3187.namprd11.prod.outlook.com \
--to=cheng1.jiang@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=wenwux.ma@intel.com \
--cc=xuan.ding@intel.com \
--cc=yuanx.wang@intel.com \
--cc=yvonnex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).