From: "Jiang, Cheng1" <cheng1.jiang@intel.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"Matz, Olivier" <olivier.matz@6wind.com>,
"Ma, WenwuX" <wenwux.ma@intel.com>,
"Zhang, Yuying" <yuying.zhang@intel.com>,
"Singh, Aman Deep" <aman.deep.singh@intel.com>
Subject: RE: [PATCH v2 5/6] net/vhost: perform SW checksum in Rx path
Date: Fri, 10 Jun 2022 07:19:10 +0000 [thread overview]
Message-ID: <BL0PR11MB3187D357F26DED137A9473E9DCA69@BL0PR11MB3187.namprd11.prod.outlook.com> (raw)
In-Reply-To: <SN6PR11MB3504A7350CE14609C9B3DFB39CA69@SN6PR11MB3504.namprd11.prod.outlook.com>
Hi Maxime,
> -----Original Message-----
> From: Xia, Chenbo <chenbo.xia@intel.com>
> Sent: Friday, June 10, 2022 11:49 AM
> To: Maxime Coquelin <maxime.coquelin@redhat.com>; dev@dpdk.org;
> jasowang@redhat.com; david.marchand@redhat.com; Matz, Olivier
> <olivier.matz@6wind.com>; Ma, WenwuX <wenwux.ma@intel.com>; Zhang,
> Yuying <yuying.zhang@intel.com>; Singh, Aman Deep
> <aman.deep.singh@intel.com>; Jiang, Cheng1 <cheng1.jiang@intel.com>
> Subject: RE: [PATCH v2 5/6] net/vhost: perform SW checksum in Rx path
>
> + Cheng for review
>
> > -----Original Message-----
> > From: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Sent: Wednesday, June 8, 2022 8:50 PM
> > To: dev@dpdk.org; jasowang@redhat.com; Xia, Chenbo
> > <chenbo.xia@intel.com>; david.marchand@redhat.com; Matz, Olivier
> > <olivier.matz@6wind.com>; Ma, WenwuX <wenwux.ma@intel.com>;
> Zhang,
> > Yuying <yuying.zhang@intel.com>; Singh, Aman Deep
> > <aman.deep.singh@intel.com>
> > Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Subject: [PATCH v2 5/6] net/vhost: perform SW checksum in Rx path
> >
> > Virtio specification supports host checksum offloading for L4, which
> > is enabled with VIRTIO_NET_F_CSUM feature negotiation. However, the
> > Vhost PMD does not advertise Rx checksum offload capabilities, so we
> > can end-up with the VIRTIO_NET_F_CSUM feature being negotiated,
> > implying the Vhost library returns packets with checksum being
> > offloaded while the application did not request for it.
> >
> > Advertising these offload capabilities at the ethdev level is not
> > enough, because we could still end-up with the application not
> > enabling these offloads while the guest still negotiate them.
> >
> > This patch advertises the Rx checksum offload capabilities, and
> > introduces a compatibility layer to cover the case VIRTIO_NET_F_CSUM
> > has been negotiated but the application does not configure the Rx
> > checksum offloads. This function performis the L4 Rx checksum in SW
> > for UDP and TCP. Note that it is not needed to calculate the
> > pseudo-header checksum, because the Virtio specification requires that
> > the driver do it.
> >
> > This patch does not advertise SCTP checksum offloading capability for
> > now, but it could be handled later if the need arises.
> >
> > Reported-by: Jason Wang <jasowang@redhat.com>
> > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > ---
> >
Reviewed-by: Cheng Jiang <cheng1.jiang@intel.com>
next prev parent reply other threads:[~2022-06-10 7:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 12:49 [PATCH v2 0/6] Vhost checksum offload improvements Maxime Coquelin
2022-06-08 12:49 ` [PATCH v2 1/6] Revert "app/testpmd: modify mac in csum forwarding" Maxime Coquelin
2022-06-13 12:24 ` Singh, Aman Deep
2022-06-17 12:42 ` Maxime Coquelin
2022-06-08 12:49 ` [PATCH v2 2/6] vhost: fix missing enqueue pseudo-header calculation Maxime Coquelin
2022-06-08 12:49 ` [PATCH v2 3/6] net/vhost: enable compliant offloading mode Maxime Coquelin
2022-06-08 12:49 ` [PATCH v2 4/6] net/vhost: make VLAN stripping flag a boolean Maxime Coquelin
2022-06-08 12:49 ` [PATCH v2 5/6] net/vhost: perform SW checksum in Rx path Maxime Coquelin
2022-06-09 1:59 ` Xia, Chenbo
2022-06-10 3:49 ` Xia, Chenbo
2022-06-10 7:19 ` Jiang, Cheng1 [this message]
2022-06-08 12:49 ` [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path Maxime Coquelin
2022-06-09 2:26 ` Xia, Chenbo
2022-06-10 3:49 ` Xia, Chenbo
2022-06-10 7:31 ` Jiang, Cheng1
2022-06-10 3:50 ` Xia, Chenbo
2022-06-17 14:06 ` [PATCH v2 0/6] Vhost checksum offload improvements Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB3187D357F26DED137A9473E9DCA69@BL0PR11MB3187.namprd11.prod.outlook.com \
--to=cheng1.jiang@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jasowang@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=wenwux.ma@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).