From: "Su, Simei" <simei.su@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Guo, Jia" <jia.guo@intel.com>,
"Guo, Junfeng" <junfeng.guo@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: add new RSS offload types
Date: Thu, 2 Jul 2020 01:14:57 +0000 [thread overview]
Message-ID: <BL0PR11MB338016BA571420E60B666DEC9C6D0@BL0PR11MB3380.namprd11.prod.outlook.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E7061154849DE3@SHSMSX103.ccr.corp.intel.com>
Hi, Qi
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Wednesday, July 1, 2020 9:28 PM
> To: Su, Simei <simei.su@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; Guo, Junfeng
> <junfeng.guo@intel.com>
> Subject: RE: [PATCH 1/3] ethdev: add new RSS offload types
>
>
>
> > -----Original Message-----
> > From: Su, Simei <simei.su@intel.com>
> > Sent: Friday, June 12, 2020 10:20 AM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong
> > <xiaolong.ye@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> > Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; Guo, Junfeng
> > <junfeng.guo@intel.com>; Su, Simei <simei.su@intel.com>
> > Subject: [PATCH 1/3] ethdev: add new RSS offload types
> >
> > This patch defines new RSS offload types for PPPoE and session id is
> > assumed to be the default RSS input set.
>
> Not sure if it is necessary to force the default RSS input set as session id for
> PPPoE, So maybe reword to below:
> Typically Session Id would be the RSS input set for a PPPoE packet, but as a
> hint each driver may have different default behavior
>
I mean if we use ETH_RSS_PPPoE, itself represents the input set "session id". Maybe I can reword:
session id is assumed to be the default RSS input set for ETH_RSS_PPPoE.
Do you think it's ok ?
Br
Simei
> >
> > Signed-off-by: Simei Su <simei.su@intel.com>
> > ---
> > lib/librte_ethdev/rte_ethdev.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_ethdev/rte_ethdev.h
> > b/lib/librte_ethdev/rte_ethdev.h index a49242b..631b146 100644
> > --- a/lib/librte_ethdev/rte_ethdev.h
> > +++ b/lib/librte_ethdev/rte_ethdev.h
> > @@ -521,7 +521,7 @@ struct rte_eth_rss_conf {
> > #define ETH_RSS_AH (1ULL << 28)
> > #define ETH_RSS_L2TPV3 (1ULL << 29)
> > #define ETH_RSS_PFCP (1ULL << 30)
> > -
> > +#define ETH_RSS_PPPOE (1ULL << 31)
> >
> > /*
> > * We use the following macros to combine with above ETH_RSS_* for
> > --
> > 1.8.3.1
>
next prev parent reply other threads:[~2020-07-02 1:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 2:20 [dpdk-dev] [PATCH 0/3] net/ice: enable advanced RSS for PPPoE Simei Su
2020-06-12 2:20 ` [dpdk-dev] [PATCH 1/3] ethdev: add new RSS offload types Simei Su
2020-07-01 13:28 ` Zhang, Qi Z
2020-07-02 1:14 ` Su, Simei [this message]
2020-06-12 2:20 ` [dpdk-dev] [PATCH 2/3] app/testpmd: support extended " Simei Su
2020-06-12 2:20 ` [dpdk-dev] [PATCH 3/3] net/ice: add RSS support for PPPoE Simei Su
2020-07-02 5:11 ` [dpdk-dev] [PATCH v2 0/3] net/ice: enable advanced RSS " Simei Su
2020-07-02 5:11 ` [dpdk-dev] [PATCH v2 1/3] ethdev: add new RSS offload types Simei Su
2020-07-03 13:50 ` Zhang, Qi Z
2020-07-07 9:50 ` Ferruh Yigit
2020-07-02 5:11 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: support extended " Simei Su
2020-07-07 12:02 ` Ferruh Yigit
2020-07-02 5:11 ` [dpdk-dev] [PATCH v2 3/3] net/ice: add RSS support for PPPoE Simei Su
2020-07-07 0:24 ` [dpdk-dev] [PATCH v2 0/3] net/ice: enable advanced RSS " Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB338016BA571420E60B666DEC9C6D0@BL0PR11MB3380.namprd11.prod.outlook.com \
--to=simei.su@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=junfeng.guo@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).