From: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Patil, Harish" <Harish.Patil@cavium.com>
Subject: Re: [dpdk-dev] net/qede/base: build is broken on FreeBSD 11.0 with clang 3.8.0
Date: Wed, 18 Jan 2017 01:33:50 +0000 [thread overview]
Message-ID: <BLUPR0701MB1572540798F519B8BA60CE4C9F7F0@BLUPR0701MB1572.namprd07.prod.outlook.com> (raw)
In-Reply-To: <1369b769-d822-1a3f-e2de-57c3cd211512@solarflare.com>
> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
> Sent: Tuesday, January 17, 2017 7:00 AM
>
> Hi,
>
> build is broken for me on FreeBSD 11.0. Just default config and gmake:
>
> == Build drivers/net/qede
> CC base/ecore_dev.o
> CC base/ecore_hw.o
> CC base/ecore_cxt.o
> /tmp/dpdk-next-net/drivers/net/qede/base/ecore_cxt.c:1257:2: error:
> shifting a negative signed value is undefined [-Werror,-Wshift-negative-
> value]
> SET_FIELD(cdu_params, CDUC_NCIB, elems_per_page);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /tmp//dpdk-next-net/drivers/net/qede/base/ecore.h:82:27: note:
> expanded from macro 'SET_FIELD'
> (value) &= ~(name##_MASK << name##_SHIFT); \
> ~~~~~~~~~~~ ^
> /tmp/dpdk-next-net/drivers/net/qede/base/ecore_cxt.c:1268:2: error:
> shifting a negative signed value is undefined [-Werror,-Wshift-negative-
> value]
> SET_FIELD(cdu_params, CDUT_TYPE0_CXT_SIZE, (cxt_size >> 3));
>
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~
> /tmp/dpdk-next-net/drivers/net/qede/base/ecore.h:82:27: note:
> expanded from macro 'SET_FIELD'
> (value) &= ~(name##_MASK << name##_SHIFT); \
> ~~~~~~~~~~~ ^
> /tmp/dpdk-next-net/drivers/net/qede/base/ecore_cxt.c:1280:2: error:
> shifting a negative signed value is undefined [-Werror,-Wshift-negative-
> value]
> SET_FIELD(cdu_params, CDUT_TYPE1_CXT_SIZE, (cxt_size >> 3));
>
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~
> /tmp/dpdk-next-net/drivers/net/qede/base/ecore.h:82:27: note:
> expanded from macro 'SET_FIELD'
> (value) &= ~(name##_MASK << name##_SHIFT); \
> ~~~~~~~~~~~ ^
> 3 errors generated.
> gmake[5]: *** [/tmp/dpdk-next-net/mk/internal/rte.compile-pre.mk:140:
> base/ecore_cxt.o] Error 1
> gmake[4]: *** [/tmp/dpdk-next-net/mk/rte.subdir.mk:63: qede] Error 2
> gmake[3]: *** [/tmp/dpdk-next-net/mk/rte.subdir.mk:63: net] Error 2
> gmake[2]: *** [/tmp/dpdk-next-net/mk/rte.sdkbuild.mk:80: drivers] Error 2
> gmake[1]: *** [/tmp/dpdk-next-net/mk/rte.sdkroot.mk:127: all] Error 2
> gmake: *** [Makefile:12: all] Error 2
>
> $ clang --version
> FreeBSD clang version 3.8.0 (tags/RELEASE_380/final 262564) (based on LLVM
> 3.8.0)
> Target: x86_64-unknown-freebsd11.0
> Thread model: posix
> InstalledDir: /usr/bin
We didn’t see these errors reported in our internal testing.
FreeBSD clang version 3.6.1 (tags/RELEASE_361/final 237755) 20150525
Target: x86_64-unknown-freebsd11.0
Thread model: posix
We'll update our FreeBSD clang compiler version to test against 3.8.0.
Thanks!
-Rasesh
> Andrew.
next prev parent reply other threads:[~2017-01-18 1:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 14:59 Andrew Rybchenko
2017-01-17 22:04 ` Thomas Monjalon
2017-01-17 22:06 ` Thomas Monjalon
2017-01-18 1:33 ` Mody, Rasesh [this message]
2017-01-18 20:45 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLUPR0701MB1572540798F519B8BA60CE4C9F7F0@BLUPR0701MB1572.namprd07.prod.outlook.com \
--to=rasesh.mody@cavium.com \
--cc=Harish.Patil@cavium.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).