From: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>
Subject: Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to get vendor/device id info
Date: Tue, 20 Dec 2016 23:25:44 +0000 [thread overview]
Message-ID: <BLUPR0701MB1572FF98488B3EB37BEC38259F900@BLUPR0701MB1572.namprd07.prod.outlook.com> (raw)
In-Reply-To: <eba57a02-fccd-d0e7-f271-421981e11c7d@intel.com>
Hi Ferruh,
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Friday, December 09, 2016 5:36 AM
>
> Hi Rasesh,
>
> On 12/3/2016 6:35 AM, Rasesh Mody wrote:
> > Fixes: ec94dbc5 ("qede: add base driver")
> >
> > Signed-off-by: Rasesh Mody <Rasesh.Mody@cavium.com>
>
> Related to the commit logs of this patchset. Many people, including me,
> won't know technical details of your driver as you do.
>
> From below patch, I also can see vendor_id and device_id get, which were
> not there before. But I have no clue why? Or what happens when you don't
> have them, or what works fine when you have them.
> Overall a little context helps a lot to understand what is really fixed, and what
> happens if not fixed.
The vendor_id and device_id are used to determine device type. If you don't have them, then check for determining device type fails and is always set to default device type.
Hope this helps.
> For example in patch 8/8, it is a one line easy modification :), but there is no
> way that I can understand what really it does, but commit log comes to help
> there, and describes it really fixes VF over legacy PF, by VF asking a FW
> overwrite instead of failing on PF reject msg. So patch subject can be here:
> fix VF over legacy PF.
Sounds good, will reword the subject.
> Please trying to provide more context on fixes.
>
>
> Also you need to add CC:stable@dpdk.org to commit log, so that git send-
> email ensures this fixes also sent to stable trees.
Will take care of this in v2 submission.
Thanks!
Rasesh
>
>
> Thanks,
>
> > ---
> > drivers/net/qede/qede_ethdev.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/net/qede/qede_ethdev.c
> > b/drivers/net/qede/qede_ethdev.c index 9c2a5eae..b9a325df 100644
> > --- a/drivers/net/qede/qede_ethdev.c
> > +++ b/drivers/net/qede/qede_ethdev.c
> > @@ -2071,6 +2071,10 @@ static int qede_common_dev_init(struct
> > rte_eth_dev *eth_dev, bool is_vf)
> >
> > rte_eth_copy_pci_info(eth_dev, pci_dev);
> >
> > + /* @DPDK */
> > + edev->vendor_id = pci_dev->id.vendor_id;
> > + edev->device_id = pci_dev->id.device_id;
> > +
> > qed_ops = qed_get_eth_ops();
> > if (!qed_ops) {
> > DP_ERR(edev, "Failed to get qed_eth_ops_pass\n");
> >
next prev parent reply other threads:[~2016-12-20 23:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 6:35 Rasesh Mody
2016-12-03 6:35 ` [dpdk-dev] [PATCH 2/8] net/qede/base: fix sriov printouts Rasesh Mody
2016-12-03 6:35 ` [dpdk-dev] [PATCH 3/8] net/qede/base: fix multiple acquisition requests by VF Rasesh Mody
2016-12-03 6:35 ` [dpdk-dev] [PATCH 4/8] net/qede/base: fix error return code in resc alloc Rasesh Mody
2016-12-03 6:35 ` [dpdk-dev] [PATCH 5/8] net/qede/base: fix mutex in freeing context manager Rasesh Mody
2016-12-03 6:35 ` [dpdk-dev] [PATCH 6/8] net/qede/base: fix Rx queue access by malicious VFs Rasesh Mody
2016-12-03 6:35 ` [dpdk-dev] [PATCH 7/8] net/qede/base: fix to handle acquire request from VF Rasesh Mody
2016-12-03 6:35 ` [dpdk-dev] [PATCH 8/8] net/qede/base: fix to check FW override after rejection Rasesh Mody
2016-12-09 13:35 ` [dpdk-dev] [PATCH 1/8] net/qede: fix to get vendor/device id info Ferruh Yigit
2016-12-20 23:25 ` Mody, Rasesh [this message]
2016-12-23 0:49 ` [dpdk-dev] [PATCH v2 " Rasesh Mody
2016-12-23 15:26 ` Ferruh Yigit
2016-12-23 0:49 ` [dpdk-dev] [PATCH v2 2/8] net/qede/base: fix sriov printouts Rasesh Mody
2016-12-23 0:49 ` [dpdk-dev] [PATCH v2 3/8] net/qede/base: fix multiple acquisition requests by VF Rasesh Mody
2016-12-23 0:50 ` [dpdk-dev] [PATCH v2 4/8] net/qede/base: fix error return code in resc alloc Rasesh Mody
2016-12-23 0:50 ` [dpdk-dev] [PATCH v2 5/8] net/qede/base: fix mutex in freeing context manager Rasesh Mody
2016-12-23 0:50 ` [dpdk-dev] [PATCH v2 6/8] net/qede/base: fix Rx queue access by malicious VFs Rasesh Mody
2016-12-23 0:50 ` [dpdk-dev] [PATCH v2 7/8] net/qede/base: fix to handle acquire request from VF Rasesh Mody
2016-12-23 0:50 ` [dpdk-dev] [PATCH v2 8/8] net/qede/base: fix VF over legacy PF Rasesh Mody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLUPR0701MB1572FF98488B3EB37BEC38259F900@BLUPR0701MB1572.namprd07.prod.outlook.com \
--to=rasesh.mody@cavium.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).