From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: mattias.ronnblom <mattias.ronnblom@ericsson.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
Jerin Jacob <jerinjacobk@gmail.com>,
Sunil Kumar Kori <skori@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
"Nipun Gupta" <nipun.gupta@nxp.com>,
Thomas Monjalon <thomas@monjalon.net>,
"David Marchand" <david.marchand@redhat.com>,
"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
"Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Akhil Goyal <gakhil@marvell.com>,
mattias.ronnblom <mattias.ronnblom@ericsson.com>
Subject: Re: [dpdk-dev] [PATCH] eventdev: negate maintenance capability flag
Date: Wed, 10 Nov 2021 09:55:50 +0000 [thread overview]
Message-ID: <BN0PR11MB57126C35FAA6D7C7A6CD28B8D7939@BN0PR11MB5712.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211110092906.20980-1-mattias.ronnblom@ericsson.com>
> -----Original Message-----
> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> Sent: Wednesday, November 10, 2021 9:29 AM
> To: jerinj@marvell.com; Jerin Jacob <jerinjacobk@gmail.com>; Sunil Kumar Kori
> <skori@marvell.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>; Nipun Gupta
> <nipun.gupta@nxp.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> Thomas Monjalon <thomas@monjalon.net>; David Marchand
> <david.marchand@redhat.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>; Carrillo, Erik G <erik.g.carrillo@intel.com>;
> Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Akhil Goyal <gakhil@marvell.com>; mattias.ronnblom
> <mattias.ronnblom@ericsson.com>
> Subject: [PATCH] eventdev: negate maintenance capability flag
>
> Replace RTE_EVENT_DEV_CAP_REQUIRES_MAINT, which signaled the need
> for the application to call rte_event_maintain(), with
> RTE_EVENT_DEV_CAP_MAINTENANCE_FREE, which does the opposite (i.e.,
> signifies that the event device does not require maintenance).
>
> This approach is more in line with how other eventdev hardware and/or
> software limitations are handled in the Eventdev API.
>
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Generally patch looks fine to me, but on testing I got a strange warning from the
compiler on the OPDL driver:
In file included from ../drivers/event/opdl/opdl_evdev.h:8,
from ../drivers/event/opdl/opdl_evdev.c:15:
../drivers/event/opdl/opdl_evdev.c: In function ‘opdl_info_get’:
../lib/eventdev/rte_eventdev.h:302:44: warning: conversion from ‘long long unsigned int’ to ‘un
signed char’ changes value from ‘1024’ to ‘0’ [-Woverflow]
302 | #define RTE_EVENT_DEV_CAP_MAINTENANCE_FREE (1ULL << 10)
| ^
../drivers/event/opdl/opdl_evdev.c:379:34: note: in expansion of macro ‘RTE_EVENT_DEV_CAP_MAINT
ENANCE_FREE’
379 | RTE_EVENT_DEV_CAP_MAINTENANCE_FREE,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Investigating, RTE_EVENT_DEV_CAP_* are assigned to struct rte_event_dev_info::event_dev_cap,
which is a uint32_t. The error suggests that the variable being assigned to is a "unsigned char"?
<snip>
> static void
> diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c
> index 5007e9a7bf..787ee4713d 100644
> --- a/drivers/event/opdl/opdl_evdev.c
> +++ b/drivers/event/opdl/opdl_evdev.c
> @@ -376,6 +376,7 @@ opdl_info_get(struct rte_eventdev *dev, struct
> rte_event_dev_info *info)
> .max_num_events = OPDL_INFLIGHT_EVENTS_TOTAL,
> .event_dev_cap = RTE_EVENT_DEV_CAP_BURST_MODE |
> RTE_EVENT_DEV_CAP_CARRY_FLOW_ID,
> + RTE_EVENT_DEV_CAP_MAINTENANCE_FREE,
> };
Aha! Replace:
> RTE_EVENT_DEV_CAP_CARRY_FLOW_ID,
with:
> RTE_EVENT_DEV_CAP_CARRY_FLOW_ID |
The "," character was causing the _FREE flag to not be combined with the previous
flags field, instead being its own (unnamed?) assignment to the struct rte_event_dev_info.
With that , to | change, all looks good to me. -Harry
next prev parent reply other threads:[~2021-11-10 9:56 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 11:12 [dpdk-dev] [PATCH 1/3] doc: add skeleton for eventdevs feature metrices Sunil Kumar Kori
2019-11-07 11:12 ` [dpdk-dev] [PATCH 2/3] doc: update eventdev feature matrix for octeontx2 Sunil Kumar Kori
2019-11-07 11:12 ` [dpdk-dev] [PATCH 3/3] doc: update eventdev feature matrix for octeontx Sunil Kumar Kori
2019-11-15 7:38 ` [dpdk-dev] [PATCH 1/3] doc: add skeleton for eventdevs feature metrices Jerin Jacob
2019-11-21 7:44 ` [dpdk-dev] [PATCH v2 1/3] doc: add skeleton for eventdevs feature matrices Sunil Kumar Kori
2019-11-21 7:44 ` [dpdk-dev] [PATCH v2 2/3] doc: update eventdev feature matrix for octeontx2 Sunil Kumar Kori
2019-11-21 7:44 ` [dpdk-dev] [PATCH v2 3/3] doc: update eventdev feature matrix for octeontx Sunil Kumar Kori
2019-11-28 15:49 ` [dpdk-dev] [PATCH v2 1/3] doc: add skeleton for eventdevs feature matrices Thomas Monjalon
2019-12-03 6:27 ` [dpdk-dev] [PATCH v3 " Sunil Kumar Kori
2019-12-03 6:27 ` [dpdk-dev] [PATCH v3 2/3] doc: update eventdev feature matrix for octeontx2 Sunil Kumar Kori
2019-12-03 6:27 ` [dpdk-dev] [PATCH v3 3/3] doc: update eventdev feature matrix for octeontx Sunil Kumar Kori
2020-02-27 7:02 ` [dpdk-dev] [PATCH v4 1/3] doc: add skeleton for eventdevs feature matrices Sunil Kumar Kori
2020-02-27 7:03 ` [dpdk-dev] [PATCH v4 2/3] doc: update eventdev feature matrix for octeontx2 Sunil Kumar Kori
2020-02-27 7:03 ` [dpdk-dev] [PATCH v4 3/3] doc: update eventdev feature matrix for octeontx Sunil Kumar Kori
2021-10-22 7:48 ` [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices skori
2021-10-22 7:48 ` [dpdk-dev] [PATCH v5 2/4] doc: update eventdev feature matrix for octeontx2 skori
2021-10-22 7:48 ` [dpdk-dev] [PATCH v5 3/4] doc: update eventdev feature matrix for octeontx skori
2021-10-22 7:48 ` [dpdk-dev] [PATCH v5 4/4] doc: update eventdev feature matrix for cnxk skori
2021-11-09 10:11 ` [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices Jerin Jacob
2021-11-09 11:34 ` Thomas Monjalon
2021-11-11 6:40 ` [EXT] " Sunil Kumar Kori
2021-11-10 8:42 ` Mattias Rönnblom
2021-11-10 8:50 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2021-11-10 9:29 ` [dpdk-dev] [PATCH] eventdev: negate maintenance capability flag Mattias Rönnblom
2021-11-10 9:55 ` Van Haaren, Harry [this message]
2021-11-10 10:06 ` [dpdk-dev] [PATCH v2] " Mattias Rönnblom
2021-11-10 10:07 ` [dpdk-dev] [PATCH] " Mattias Rönnblom
2021-11-10 10:43 ` Jerin Jacob
2021-11-10 11:32 ` [dpdk-dev] [PATCH v3] " Mattias Rönnblom
2021-11-10 18:55 ` Jerin Jacob
2021-11-10 11:14 ` [dpdk-dev] [PATCH v2] eventdev: fix Rx adapter stalls on event device backpressure Mattias Rönnblom
2021-11-10 11:23 ` Jayatheerthan, Jay
2021-11-10 18:56 ` Jerin Jacob
2021-11-15 13:15 ` [PATCH v6 01/11] doc: add skeleton for eventdevs feature matrices skori
2021-11-15 13:15 ` [PATCH v6 02/11] doc: update eventdev feature matrix for octeontx skori
2021-11-15 13:15 ` [PATCH v6 03/11] doc: update eventdev feature matrix for octeontx2 skori
2021-11-15 13:15 ` [PATCH v6 04/11] doc: update eventdev feature matrix for cn9k skori
2021-11-15 13:15 ` [PATCH v6 05/11] doc: update eventdev feature matrix for cn10k skori
2021-11-15 13:15 ` [PATCH v6 06/11] doc: update eventdev feature matrix for dpaa skori
2021-11-15 13:15 ` [PATCH v6 07/11] doc: update eventdev feature matrix for dpaa2 skori
2021-11-15 13:15 ` [PATCH v6 08/11] doc: update eventdev feature matrix for SW skori
2021-11-15 13:15 ` [PATCH v6 09/11] doc: update eventdev feature matrix for opdl skori
2021-11-15 13:15 ` [PATCH v6 10/11] doc: update eventdev feature matrix for dsw skori
2021-11-15 13:15 ` [PATCH v6 11/11] devtools: check event device doc tables skori
2021-11-22 7:54 ` [PATCH v7 01/11] doc: add skeleton for eventdevs feature matrices skori
2021-11-22 7:54 ` [PATCH v7 02/11] doc: update eventdev feature matrix for octeontx skori
2021-11-22 7:54 ` [PATCH v7 03/11] doc: update eventdev feature matrix for octeontx2 skori
2021-11-22 7:54 ` [PATCH v7 04/11] doc: update eventdev feature matrix for cn9k skori
2021-11-22 7:54 ` [PATCH v7 05/11] doc: update eventdev feature matrix for cn10k skori
2021-11-22 18:25 ` Jerin Jacob
2021-11-22 7:54 ` [PATCH v7 06/11] doc: update eventdev feature matrix for dpaa skori
2021-11-22 7:54 ` [PATCH v7 07/11] doc: update eventdev feature matrix for dpaa2 skori
2021-11-22 7:54 ` [PATCH v7 08/11] doc: update eventdev feature matrix for SW skori
2021-11-22 7:54 ` [PATCH v7 09/11] doc: update eventdev feature matrix for opdl skori
2021-11-22 7:54 ` [PATCH v7 10/11] doc: update eventdev feature matrix for dsw skori
2021-11-22 7:54 ` [PATCH v7 11/11] devtools: check event device doc tables skori
2021-11-22 18:35 ` Jerin Jacob
2021-11-23 11:07 ` [PATCH v8 01/10] doc: add skeleton for eventdevs feature matrices skori
2021-11-23 11:07 ` [PATCH v8 02/10] doc: update eventdev feature matrix for octeontx skori
2021-11-23 11:07 ` [PATCH v8 03/10] doc: update eventdev feature matrix for octeontx2 skori
2021-11-23 11:07 ` [PATCH v8 04/10] doc: update eventdev feature matrix for cnxk skori
2021-11-23 11:07 ` [PATCH v8 05/10] doc: update eventdev feature matrix for dpaa skori
2021-11-23 11:07 ` [PATCH v8 06/10] doc: update eventdev feature matrix for dpaa2 skori
2021-11-23 11:07 ` [PATCH v8 07/10] doc: update eventdev feature matrix for SW skori
2021-11-23 11:07 ` [PATCH v8 08/10] doc: update eventdev feature matrix for opdl skori
2021-11-23 11:07 ` [PATCH v8 09/10] doc: update eventdev feature matrix for dsw skori
2021-11-23 11:07 ` [PATCH v8 10/10] devtools: check event device doc tables skori
2021-11-24 10:52 ` Thomas Monjalon
2021-11-24 11:16 ` [EXT] " Sunil Kumar Kori
2021-11-24 11:21 ` Thomas Monjalon
2021-11-24 10:03 ` [PATCH v8 01/10] doc: add skeleton for eventdevs feature matrices Thomas Monjalon
2021-11-24 10:30 ` [EXT] " Sunil Kumar Kori
2021-11-24 10:43 ` Thomas Monjalon
2021-11-24 12:35 ` Sunil Kumar Kori
2021-11-24 12:41 ` Thomas Monjalon
2021-11-24 12:46 ` Sunil Kumar Kori
2021-11-24 13:05 ` Sunil Kumar Kori
2021-11-24 10:48 ` Thomas Monjalon
2021-11-24 11:12 ` [EXT] " Sunil Kumar Kori
2021-11-24 12:14 ` [PATCH v1 1/1] doc: update eventdev feature matrix for dlb2 skori
2021-11-24 13:03 ` [PATCH v9 1/1] doc: add eventdevs feature matrices skori
2021-11-26 14:55 ` Thomas Monjalon
2021-11-15 18:08 ` [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for " Jerin Jacob
2021-11-23 16:44 ` Jerin Jacob
2021-11-24 8:06 ` Thomas Monjalon
2021-11-24 8:14 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN0PR11MB57126C35FAA6D7C7A6CD28B8D7939@BN0PR11MB5712.namprd11.prod.outlook.com \
--to=harry.van.haaren@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=ferruh.yigit@intel.com \
--cc=gakhil@marvell.com \
--cc=hemant.agrawal@nxp.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=nipun.gupta@nxp.com \
--cc=pbhagavatula@marvell.com \
--cc=skori@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).