From: Shally Verma <shallyv@marvell.com>
To: Arek Kusztal <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"fiona.trahe@intel.com" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v3 10/11] test: add pkcs1_5 padding simulation
Date: Wed, 17 Jul 2019 10:22:39 +0000 [thread overview]
Message-ID: <BN6PR1801MB205266AFBFC340A88DD09FECADC90@BN6PR1801MB2052.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190716185304.12592-11-arkadiuszx.kusztal@intel.com>
> -----Original Message-----
> From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> Sent: Wednesday, July 17, 2019 12:23 AM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; Shally Verma
> <shallyv@marvell.com>; Arek Kusztal <arkadiuszx.kusztal@intel.com>
> Subject: [EXT] [PATCH v3 10/11] test: add pkcs1_5 padding simulation
>
> External Email
>
> ----------------------------------------------------------------------
> This patch adds function to simulate pkcs1_5 padding, it serves nothing else
> than example. It provides no security and should not be used in security
> context.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
[Shally] Sorry did not get context of this test. Is it to describe PADDING_NONE?
> app/test/test_cryptodev_asym_util.h | 54
> +++++++++++++++++++++++++++++++++++++
> 1 file changed, 54 insertions(+)
>
> diff --git a/app/test/test_cryptodev_asym_util.h
> b/app/test/test_cryptodev_asym_util.h
> index b3d9fb4..f984166 100644
> --- a/app/test/test_cryptodev_asym_util.h
> +++ b/app/test/test_cryptodev_asym_util.h
> @@ -1,10 +1,64 @@
> /* SPDX-License-Identifier: BSD-3-Clause
> * Copyright(c) 2018 Cavium Networks
> + * Copyright (c) 2019 Intel Corporation
> */
>
> #ifndef TEST_CRYPTODEV_ASYM_TEST_UTIL_H__ #define
> TEST_CRYPTODEV_ASYM_TEST_UTIL_H__
>
> +/*
> + * Two functions below simulate pkcs 1.5 padding and serves only as an
> +example,
> + * both offer no security.
> + */
> +static inline int rsa_simulate_pkcs1_5_padding(int op, uint8_t *p,
> + int key_size, const uint8_t *src, int len) {
> +
> + int ps_len;
> +
> + if (len > key_size - 11)
> + return -1;
> + ps_len = key_size - len - 3;
> +
> + *(p++) = 0;
> + *(p++) = op ? 1 : 2;
> + if (op) {
> + while (ps_len--)
> + *(p++) = 0xFF;
> + } else {
> + while (ps_len--) {
> + *p = (uint8_t)rand();
> + *p ^= !(*p);
> + p++;
> + }
> + }
> +
> + *(p++) = 0;
> + memcpy(p, src, len);
> +
> + return 0;
> +}
> +
> +static inline int rsa_simulate_strip_pkcs1_5_padding(uint8_t *src,
> + int key_size) {
> + uint8_t tmp[key_size], *orig_src = src;
> + int i = 1;
> + ++src;
> + while (*(src) && i < key_size) {
> + ++i;
> + ++src;
> + }
> + if (i == key_size)
> + return -1;
> +
> + ++i;
> + ++src;
> +
> + memcpy(tmp, src, key_size - i);
> + memcpy(orig_src, tmp, key_size - i);
> + return key_size - i;
> +}
> +
> +
> /* Below Apis compare resulted buffer to original test vector */
>
> static inline int rsa_verify(struct rsa_test_data *rsa_param,
> --
> 2.1.0
next prev parent reply other threads:[~2019-07-17 10:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 18:52 [dpdk-dev] [PATCH v3 00/11] Rework API for RSA algorithm in asymmetric crypto Arek Kusztal
2019-07-16 18:52 ` [dpdk-dev] [PATCH v3 01/11] cryptodev: change RSA API comments about primes Arek Kusztal
2019-07-17 7:32 ` [dpdk-dev] [EXT] " Shally Verma
2019-07-17 8:39 ` Kusztal, ArkadiuszX
2019-07-16 18:52 ` [dpdk-dev] [PATCH v3 02/11] cryptodev: add cipher field to RSA op Arek Kusztal
2019-07-17 7:39 ` [dpdk-dev] [EXT] " Shally Verma
2019-07-17 16:01 ` Kusztal, ArkadiuszX
2019-07-16 18:52 ` [dpdk-dev] [PATCH v3 03/11] crypto/openssl: add cipher field to openssl RSA implementation Arek Kusztal
2019-07-17 7:50 ` [dpdk-dev] [EXT] " Shally Verma
2019-07-16 18:52 ` [dpdk-dev] [PATCH v3 04/11] test: add cipher field to RSA test Arek Kusztal
2019-07-17 7:41 ` [dpdk-dev] [EXT] " Shally Verma
2019-07-17 8:27 ` Kusztal, ArkadiuszX
2019-07-17 9:42 ` Kusztal, ArkadiuszX
2019-07-17 12:54 ` Shally Verma
2019-07-18 12:44 ` Trahe, Fiona
2019-07-19 4:10 ` Shally Verma
2019-07-16 18:52 ` [dpdk-dev] [PATCH v3 05/11] cryptodev: add information about message format when signing with RSA Arek Kusztal
2019-07-17 10:07 ` [dpdk-dev] [EXT] " Shally Verma
2019-07-17 10:26 ` Kusztal, ArkadiuszX
2019-07-16 18:52 ` [dpdk-dev] [PATCH v3 06/11] cryptodev: remove RSA PKCS1 BT0 padding Arek Kusztal
2019-07-17 10:09 ` [dpdk-dev] [EXT] " Shally Verma
2019-07-16 18:53 ` [dpdk-dev] [PATCH v3 07/11] openssl: remove RSA PKCS1_5 " Arek Kusztal
2019-07-17 10:18 ` [dpdk-dev] [EXT] " Shally Verma
2019-07-16 18:53 ` [dpdk-dev] [PATCH v3 08/11] test: remove RSA PKCS1_5 BT0 padding from test cases Arek Kusztal
2019-07-17 10:10 ` [dpdk-dev] [EXT] " Shally Verma
2019-07-16 18:53 ` [dpdk-dev] [PATCH v3 09/11] cryptodev: add RSA padding none description Arek Kusztal
2019-07-17 10:17 ` [dpdk-dev] [EXT] " Shally Verma
2019-07-17 10:40 ` Kusztal, ArkadiuszX
2019-07-16 18:53 ` [dpdk-dev] [PATCH v3 10/11] test: add pkcs1_5 padding simulation Arek Kusztal
2019-07-17 10:22 ` Shally Verma [this message]
2019-07-17 10:28 ` [dpdk-dev] [EXT] " Kusztal, ArkadiuszX
2019-07-16 18:53 ` [dpdk-dev] [PATCH v3 11/11] test: add RSA PKCS1_5 padding case when no padding selected Arek Kusztal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR1801MB205266AFBFC340A88DD09FECADC90@BN6PR1801MB2052.namprd18.prod.outlook.com \
--to=shallyv@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).