From: "Hyong Youb Kim (hyonkim)" <hyonkim@cisco.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
"John Daley (johndale)" <johndale@cisco.com>
Cc: Reshma Pattan <reshma.pattan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"xiaoyun.li@intel.com" <xiaoyun.li@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
"David Harton (dharton)" <dharton@cisco.com>
Subject: Re: [dpdk-dev] [PATCH] net: replace IP VHL DEF macro with RTE IPV4 VHL DEF
Date: Fri, 15 Nov 2019 03:57:08 +0000 [thread overview]
Message-ID: <BN7PR11MB2738F2C22CDD7AF338FEB0C2BF700@BN7PR11MB2738.namprd11.prod.outlook.com> (raw)
In-Reply-To: <e576c78a-838a-7e26-92e8-27b21b07b317@intel.com>
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Thursday, November 14, 2019 10:09 AM
> To: John Daley (johndale) <johndale@cisco.com>; Hyong Youb Kim (hyonkim)
> <hyonkim@cisco.com>
> Cc: Reshma Pattan <reshma.pattan@intel.com>; dev@dpdk.org;
> xiaoyun.li@intel.com; Bernard Iremonger <bernard.iremonger@intel.com>;
> David Harton (dharton) <dharton@cisco.com>
> Subject: Re: [PATCH] net: replace IP VHL DEF macro with RTE IPV4 VHL DEF
>
> On 11/8/2019 10:02 AM, Reshma Pattan wrote:
> > diff --git a/drivers/net/enic/enic_fm_flow.c
> b/drivers/net/enic/enic_fm_flow.c
> > index a1598b822..e3e3d737b 100644
> > --- a/drivers/net/enic/enic_fm_flow.c
> > +++ b/drivers/net/enic/enic_fm_flow.c
> > @@ -17,9 +17,6 @@
> > #include "vnic_nic.h"
> >
> > #define IP_DEFTTL 64 /* from RFC 1340. */
> > -#define IP_VERSION 0x40
> > -#define IP_HDRLEN 0x05 /* default IP header length == five 32-bits words.
> */
> > -#define IP_VHL_DEF (IP_VERSION | IP_HDRLEN)
> > #define IP6_VTC_FLOW 0x60000000
> >
> > /* Highest Item type supported by Flowman */
> > @@ -1000,7 +997,7 @@ enic_fm_copy_vxlan_encap(struct enic_flowman
> *fm,
> > sizeof(struct rte_vxlan_hdr);
> > append_template(&template, &off, item->spec,
> > sizeof(struct rte_ipv4_hdr));
> > - ip4->version_ihl = IP_VHL_DEF;
> > + ip4->version_ihl = RTE_IPV4_VHL_DEF;
> > if (ip4->time_to_live == 0)
> > ip4->time_to_live = IP_DEFTTL;
> > ip4->next_proto_id = IPPROTO_UDP;
>
> + David Harton, there was some comment from him in relevant issue
>
> Hi John, Hyong Youb,
>
> Are you OK with the changes in the PMD?
>
Yes, looks good to me. Thanks for pinging us.
Acked-by: Hyong Youb Kim <hyonkim@cisco.com>
-Hyong
next prev parent reply other threads:[~2019-11-15 3:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 10:02 Reshma Pattan
2019-11-14 18:09 ` Ferruh Yigit
2019-11-15 3:57 ` Hyong Youb Kim (hyonkim) [this message]
2019-11-15 15:42 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN7PR11MB2738F2C22CDD7AF338FEB0C2BF700@BN7PR11MB2738.namprd11.prod.outlook.com \
--to=hyonkim@cisco.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=dharton@cisco.com \
--cc=ferruh.yigit@intel.com \
--cc=johndale@cisco.com \
--cc=reshma.pattan@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).