From: Mathew S Thoennes <tardis@us.ibm.com>
To: David Marchand <david.marchand@redhat.com>,
David Miller <dmiller423@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Olivier Matz <olivier.matz@6wind.com>,
Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Yuying Zhang <Yuying.Zhang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
Qiming Yang <qiming.yang@intel.com>,
Wenjun Wu <wenjun1.wu@intel.com>,
Jakub Grajciar <jgrajcia@cisco.com>,
Harman Kalra <hkalra@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>,
David Christensen <drc@linux.vnet.ibm.com>
Subject: RE: [PATCH v3] Add support for IBM Z s390x
Date: Mon, 14 Aug 2023 13:03:28 +0000 [thread overview]
Message-ID: <BN7PR15MB2436A158733E387B5571DA4EE217A@BN7PR15MB2436.namprd15.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8x8Gxw+F2DseObGwaQO-o1h2u5MYxQS7aAEs1_WEB4X=A@mail.gmail.com>
David,
I will connect with David Christensen in regards to what they are doing for CI. I have talked to him in the past but now that things are rolling I will reconnect with him. I do have hardware that the CI could run on to verify the build. I think testing of the hardware part would end up being at some regular interval since that will have to occur on internal infrastructure.
Matt.....
Mathew Thoennes
zSystems Research
T.J. Watson Research Center
tardis@us.ibm.com
(914)945-4545
-----Original Message-----
From: David Marchand <david.marchand@redhat.com>
Sent: Wednesday, August 2, 2023 11:25 AM
To: David Miller <dmiller423@gmail.com>
Cc: dev@dpdk.org; Mathew S Thoennes <tardis@us.ibm.com>; Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>; Olivier Matz <olivier.matz@6wind.com>; Yipeng Wang <yipeng1.wang@intel.com>; Sameh Gobriel <sameh.gobriel@intel.com>; Bruce Richardson <bruce.richardson@intel.com>; Vladimir Medvedkin <vladimir.medvedkin@intel.com>; Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>; Yuying Zhang <Yuying.Zhang@intel.com>; Beilei Xing <beilei.xing@intel.com>; Matan Azrad <matan@nvidia.com>; Viacheslav Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Qiming Yang <qiming.yang@intel.com>; Wenjun Wu <wenjun1.wu@intel.com>; Jakub Grajciar <jgrajcia@cisco.com>; Harman Kalra <hkalra@marvell.com>; Thomas Monjalon <thomas@monjalon.net>; David Christensen <drc@linux.vnet.ibm.com>
Subject: [EXTERNAL] Re: [PATCH v3] Add support for IBM Z s390x
Hello David,
On Wed, Jul 26, 2023 at 3:35 AM David Miller <dmiller423@gmail.com> wrote:
>
> Minimal changes to drivers and app to support the IBM s390x.
This seems a bit more than "minimal changes" :-).
>
> Signed-off-by: David Miller <dmiller423@gmail.com>
> Reviewed-by: Mathew S Thoennes <tardis@us.ibm.com>
> ---
> app/test-acl/main.c | 4 +
> app/test/test_acl.c | 1 +
> app/test/test_atomic.c | 7 +-
> app/test/test_cmdline_ipaddr.c | 12 +-
> app/test/test_cmdline_num.c | 110 ++++
> app/test/test_hash_functions.c | 29 +
> app/test/test_xmmt_ops.h | 14 +
> buildtools/pmdinfogen.py | 11 +-
> config/meson.build | 2 +
> config/s390x/meson.build | 51 ++
> config/s390x/s390x_linux_clang_ubuntu | 19 +
> doc/guides/nics/features/i40e.ini | 1 +
> drivers/common/mlx5/mlx5_common.h | 9 +
> drivers/net/i40e/i40e_rxtx_vec_s390x.c | 630 +++++++++++++++++++
> drivers/net/i40e/meson.build | 2 +
> drivers/net/ixgbe/ixgbe_rxtx.c | 8 +-
> drivers/net/memif/rte_eth_memif.h | 2 +
> drivers/net/mlx5/mlx5_rx.c | 24 +-
> drivers/net/octeontx/base/octeontx_pki_var.h | 6 +
> examples/l3fwd/l3fwd_em.c | 8 +
> examples/l3fwd/l3fwd_lpm_s390x.h | 137 ++++
> examples/l3fwd/l3fwd_s390x.h | 261 ++++++++
> lib/acl/acl_bld.c | 3 +
> lib/acl/acl_gen.c | 9 +
> lib/acl/acl_run_scalar.c | 8 +
> lib/acl/rte_acl.c | 27 +
> lib/acl/rte_acl.h | 5 +-
> lib/eal/s390x/include/meson.build | 16 +
> lib/eal/s390x/include/rte_atomic.h | 44 ++
> lib/eal/s390x/include/rte_byteorder.h | 43 ++
> lib/eal/s390x/include/rte_cpuflags.h | 41 ++
> lib/eal/s390x/include/rte_cycles.h | 44 ++
> lib/eal/s390x/include/rte_io.h | 184 ++++++
> lib/eal/s390x/include/rte_mcslock.h | 18 +
> lib/eal/s390x/include/rte_memcpy.h | 55 ++
> lib/eal/s390x/include/rte_pause.h | 22 +
> lib/eal/s390x/include/rte_power_intrinsics.h | 20 +
> lib/eal/s390x/include/rte_prefetch.h | 46 ++
> lib/eal/s390x/include/rte_rwlock.h | 42 ++
> lib/eal/s390x/include/rte_spinlock.h | 85 +++
> lib/eal/s390x/include/rte_ticketlock.h | 18 +
> lib/eal/s390x/include/rte_vect.h | 35 ++
> lib/eal/s390x/meson.build | 16 +
> lib/eal/s390x/rte_cpuflags.c | 91 +++
> lib/eal/s390x/rte_cycles.c | 11 +
> lib/eal/s390x/rte_hypervisor.c | 11 +
> lib/eal/s390x/rte_power_intrinsics.c | 51 ++
> lib/hash/rte_fbk_hash.h | 7 +
> lib/lpm/meson.build | 1 +
> lib/lpm/rte_lpm.h | 2 +
> lib/lpm/rte_lpm6.c | 18 +
> lib/lpm/rte_lpm_s390x.h | 130 ++++
> meson.build | 2 +
> 53 files changed, 2439 insertions(+), 14 deletions(-)
- This is too big to review.
Please split this patch separating the really minimum support (getting EAL and main libraries to build, disabling the rest that is "broken"
for s390x) then adding more components support in later patches.
RISC V and LoongArch "recent" additions are good examples.
https://patchwork.dpdk.org/project/dpdk/list/?series=23380&state=%2A&archive=both
https://patchwork.dpdk.org/project/dpdk/list/?series=24969&state=%2A&archive=both
- We need one maintainer for this new architecture.
- You'll notice that the DPDK CI reported issues, please fix them.
- What are the plans in terms of CI? We need some compilation testing and ideally some regular runtime testing.
Maybe you can reach out to IBM PPC DPDK guys, like David Christensen, to see what they are doing.
--
David Marchand
prev parent reply other threads:[~2023-08-14 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH] Add support for IBM Z s390x>
2023-07-26 1:35 ` David Miller
2023-08-02 15:25 ` David Marchand
2023-08-02 15:34 ` David Miller
2023-08-02 15:48 ` David Miller
2023-08-14 13:03 ` Mathew S Thoennes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN7PR15MB2436A158733E387B5571DA4EE217A@BN7PR15MB2436.namprd15.prod.outlook.com \
--to=tardis@us.ibm.com \
--cc=Yuying.Zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmiller423@gmail.com \
--cc=dmitry.kozliuk@gmail.com \
--cc=drc@linux.vnet.ibm.com \
--cc=hkalra@marvell.com \
--cc=jgrajcia@cisco.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=matan@nvidia.com \
--cc=olivier.matz@6wind.com \
--cc=orika@nvidia.com \
--cc=qiming.yang@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=vladimir.medvedkin@intel.com \
--cc=wenjun1.wu@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).