DPDK patches and discussions
 help / color / mirror / Atom feed
From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
To: Ori Kam <orika@nvidia.com>, Jerin Jacob <jerinjacobk@gmail.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@amd.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"NBU-Contact-Adrien Mazarguil (EXTERNAL)"
	<adrien.mazarguil@6wind.com>
Subject: RE: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer
Date: Tue, 10 Jan 2023 06:42:11 +0000	[thread overview]
Message-ID: <BN8PR18MB2482F0E0864BB5B5CD806318CFFF9@BN8PR18MB2482.namprd18.prod.outlook.com> (raw)
In-Reply-To: <MW2PR12MB466680B4D119B3BA203A2667D6EC9@MW2PR12MB4666.namprd12.prod.outlook.com>



> -----Original Message-----
> From: Ori Kam <orika@nvidia.com>
> Sent: Monday, December 26, 2022 10:30 PM
> To: Jerin Jacob <jerinjacobk@gmail.com>; Stephen Hemminger
> <stephen@networkplumber.org>
> Cc: Rakesh Kudurumalla <rkudurumalla@marvell.com>; NBU-Contact-
> Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Ferruh Yigit
> <ferruh.yigit@amd.com>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>; dev@dpdk.org; NBU-Contact-Adrien
> Mazarguil (EXTERNAL) <adrien.mazarguil@6wind.com>
> Subject: [EXT] RE: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hi All,
> 
> > -----Original Message-----
> > From: Jerin Jacob <jerinjacobk@gmail.com>
> > Sent: Thursday, 22 December 2022 7:27
> >
> > On Thu, Dec 22, 2022 at 8:32 AM Stephen Hemminger
> > <stephen@networkplumber.org> wrote:
> > >
> > > On Thu, 22 Dec 2022 07:09:02 +0530
> > > Rakesh Kudurumalla <rkudurumalla@marvell.com> wrote:
> > >
> > > > Dropping of packets based on RED can be skipped with meter action,
> > > > when RED is configured using
> > > > rte_eth_cman_config_set()
> > > >
> > > > Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> > >
> > > Should this be more general and apply to all congestion management
> > > options. Assuming the hardware can do something better than RED.
> >
> > Yes. We can use "enum rte_cman_mode mode" in the descriptor to future-
> > proof.
> 
> I'm missing the idea of this new action, I understand that is related to Jerin
> congestion patches.
> But I fail to see why we need it? Is it to mark some metadata that will have
> some effect on the congestion result? (I assume the system is implemented
> in the HW)

Yes. It is implemented in HW. Congestion management is applied on ethdev Rx queue using rte_eth_cman_config() API. Once it is configured, it applies to all the packets that steer towards that particular ethdev Rx queue. This feature help to skip the congestion management processing based on the packet color identified by the rte_flow meter object. For example, If one Rx queue configured as RED congestion  and application wants to bypass the RED congestion  processing for all GREEN color packet can be expressed though this API proposal.

  reply	other threads:[~2023-01-10  6:42 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22  1:39 Rakesh Kudurumalla
2022-12-22  1:39 ` [PATCH 2/3] app/testpmd: add skip red for testpmd Rakesh Kudurumalla
2022-12-22  1:39 ` [PATCH 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2022-12-22  3:01 ` [PATCH 1/3] lib: dpdk spec to skip red " Stephen Hemminger
2022-12-22  5:27   ` Jerin Jacob
2022-12-26 17:00     ` Ori Kam
2023-01-10  6:42       ` Rakesh Kudurumalla [this message]
2023-01-18  8:09         ` Rakesh Kudurumalla
2023-01-23 13:13           ` Jerin Jacob
2023-01-26 15:13           ` Ori Kam
2023-01-27  6:23             ` Jerin Jacob
2023-02-01 17:49               ` Ori Kam
2023-02-01 18:37                 ` Jerin Jacob
2023-02-02  7:31                   ` Ori Kam
2023-02-06  3:31                     ` Jerin Jacob
2023-01-25  7:32 ` [PATCH v2 1/3] lib: skip congestion management configuration Rakesh Kudurumalla
2023-01-25  7:32   ` [PATCH v2 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-01-25  7:32   ` [PATCH v2 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-01-25  9:26   ` [PATCH v2 1/3] lib: skip congestion management configuration Jerin Jacob
2023-02-09  7:24   ` [PATCH v3 " Rakesh Kudurumalla
2023-02-09  7:24     ` [PATCH v3 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-09  7:24     ` [PATCH v3 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-09  7:31     ` [PATCH v3 1/3] lib: skip congestion management configuration Jerin Jacob
2023-02-09  8:35     ` [PATCH v4 1/3] ethdev: " Rakesh Kudurumalla
2023-02-09  8:35       ` [PATCH v4 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-09  8:35       ` [PATCH v4 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-09 17:14         ` Jerin Jacob
2023-02-09 14:51       ` [PATCH v4 1/3] ethdev: skip congestion management configuration Ori Kam
2023-02-10  8:14       ` [PATCH v5 " Rakesh Kudurumalla
2023-02-10  8:14         ` [PATCH v5 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-10  8:14         ` [PATCH v5 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-10  8:16         ` [PATCH v5 1/3] ethdev: skip congestion management configuration Jerin Jacob
2023-02-10  8:26         ` [PATCH v6 " Rakesh Kudurumalla
2023-02-10  8:26           ` [PATCH v6 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-10 23:08             ` Ferruh Yigit
2023-02-14 13:12               ` Ferruh Yigit
2023-02-10  8:26           ` [PATCH v6 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-10 23:18             ` Ferruh Yigit
2023-02-10  9:27           ` [PATCH v6 1/3] ethdev: skip congestion management configuration Jerin Jacob
2023-02-10 23:10           ` Ferruh Yigit
2023-02-13 12:34             ` Ori Kam
2023-02-13 13:54               ` Ferruh Yigit
2023-02-13 15:44                 ` Jerin Jacob
2023-02-13 15:53                   ` Ferruh Yigit
2023-02-11  0:35           ` Ferruh Yigit
2023-02-11  5:16             ` Jerin Jacob
2023-02-12  9:00           ` [PATCH v7 " Rakesh Kudurumalla
2023-02-12  9:00             ` [PATCH v7 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-12  9:00             ` [PATCH v7 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-14 13:04             ` [PATCH v8 1/4] ethdev: skip congestion management configuration Rakesh Kudurumalla
2023-02-14 13:04               ` [PATCH v8 2/4] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-14 13:21                 ` Ferruh Yigit
2023-02-14 13:04               ` [PATCH v8 3/4] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-14 13:04               ` [PATCH v8 4/4] doc: update release notes for 23_03.rst Rakesh Kudurumalla
2023-02-14 13:19                 ` Ferruh Yigit
2023-02-14 13:13               ` [PATCH v8 1/4] ethdev: skip congestion management configuration Ferruh Yigit
2023-02-15  6:25               ` [PATCH v9 1/3] " Rakesh Kudurumalla
2023-02-15  6:25                 ` [PATCH v9 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-15  6:25                 ` [PATCH v9 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-15  9:45                   ` Ferruh Yigit
2023-02-15 10:00                   ` Nithin Kumar Dabilpuram
2023-02-15  9:43                 ` [PATCH v9 1/3] ethdev: skip congestion management configuration Ferruh Yigit
2023-02-15 17:42                 ` [PATCH v10 " Rakesh Kudurumalla
2023-02-15 17:42                   ` [PATCH v10 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-16 12:19                     ` Ferruh Yigit
2023-02-15 17:42                   ` [PATCH v10 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-16 14:51                   ` [PATCH v11 1/3] ethdev: skip congestion management configuration Rakesh Kudurumalla
2023-02-16 14:51                     ` [PATCH v11 2/3] app/testpmd: add skip cman support for testpmd Rakesh Kudurumalla
2023-02-16 14:51                     ` [PATCH v11 3/3] net/cnxk: skip red drop for ingress policer Rakesh Kudurumalla
2023-02-16 16:18                     ` [PATCH v11 1/3] ethdev: skip congestion management configuration Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN8PR18MB2482F0E0864BB5B5CD806318CFFF9@BN8PR18MB2482.namprd18.prod.outlook.com \
    --to=rkudurumalla@marvell.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=jerinjacobk@gmail.com \
    --cc=orika@nvidia.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).