From: Xuelin Shi <xuelin.shi@freescale.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] enforce rules of the cpu and ixgbe exchange data.
Date: Wed, 29 Jul 2015 07:44:55 +0000 [thread overview]
Message-ID: <BY1PR03MB1339405ED20C472E463A25F4868C0@BY1PR03MB1339.namprd03.prod.outlook.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836A68E5D@irsmsx105.ger.corp.intel.com>
Hi Thomas & Konstantin,
Thanks for the review and the comments are addressed by http://www.dpdk.org/dev/patchwork/patch/6653/
Best Regards,
Xuelin Shi
> -----Origina Konstantin l Message-----
> From: Ananyev, Konstantin [mailto:konstantin.ananyev@intel.com]
> Sent: Monday, July 27, 2015 22:43
> To: Thomas Monjalon
> Cc: Shi Xuelin-B29237; dev@dpdk.org
> Subject: RE: [PATCH v4] enforce rules of the cpu and ixgbe exchange data.
>
>
>
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Sent: Monday, July 27, 2015 3:18 PM
> > To: Ananyev, Konstantin
> > Cc: xuelin.shi@freescale.com; dev@dpdk.org
> > Subject: Re: [PATCH v4] enforce rules of the cpu and ixgbe exchange
> data.
> >
> > A quick review of this long pending patch would be great.
> > Thanks
>
> Well, it doesn't compile:
>
> /local/kananye1/dpdk.org-ixgbevfix2-tst1/drivers/net/ixgbe/ixgbe_rxtx.c:
> In function âixgbe_rx_scan_hw_ringâ:
> /local/kananye1/dpdk.org-ixgbevfix2-
> tst1/drivers/net/ixgbe/ixgbe_rxtx.c:1114:4: error: implicit declaration
> of function ârte_le_to_cpu16â [-Werror=implicit-function-declaration]
> pkt_len = rte_le_to_cpu16(rxdp[j].wb.upper.length) -
> ^
> /local/kananye1/dpdk.org-ixgbevfix2-
> tst1/drivers/net/ixgbe/ixgbe_rxtx.c:1114:4: error: nested extern
> declaration of ârte_le_to_cpu16â [-Werror=nested-externs]
>
>
> Should be rte_le_to_cpu_16(), I believe.
>
> And checkpatch.pl complains on it:
>
> WARNING: line over 80 characters
> #151: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:1133:
> +
> + rte_le_to_cpu_32(rxdp[j].wb.lower.lo_dword.data));
>
> ERROR: code indent should use tabs where possible
> #170: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:1147:
> +^I^I^I ^I rxdp[j].wb.lower.hi_dword.csum_ip.csum) &$
>
> WARNING: please, no space before tabs
> #170: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:1147:
> +^I^I^I ^I rxdp[j].wb.lower.hi_dword.csum_ip.csum) &$
>
> total: 1 errors, 2 warnings, 192 lines checked
>
> Apart from that, looks harmless :)
>
> Konstantin
>
> >
> > 2015-07-16 14:45, xuelin.shi@freescale.com:
> > > From: Xuelin Shi <xuelin.shi@freescale.com>
> > >
> > > 1. cpu use data owned by ixgbe must use rte_le_to_cpu_xx(...) 2. cpu
> > > fill data to ixgbe must use rte_cpu_to_le_xx(...) 3. checking pci
> > > status with converted constant.
> > >
> > > Signed-off-by: Xuelin Shi <xuelin.shi@freescale.com>
prev parent reply other threads:[~2015-07-29 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 6:45 xuelin.shi
2015-07-27 14:18 ` Thomas Monjalon
2015-07-27 14:43 ` Ananyev, Konstantin
2015-07-29 7:44 ` Xuelin Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY1PR03MB1339405ED20C472E463A25F4868C0@BY1PR03MB1339.namprd03.prod.outlook.com \
--to=xuelin.shi@freescale.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).