DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yong Wang <yongwang@vmware.com>
To: Shraddha Joshi <jshraddha@vmware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Shraddha Joshi <jshraddha@vmware.com>
Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: increase rx data ring descriptor size
Date: Thu, 19 Apr 2018 21:54:41 +0000	[thread overview]
Message-ID: <BY2PR05MB235946D7E91FA0F0845F969DAFB50@BY2PR05MB2359.namprd05.prod.outlook.com> (raw)
In-Reply-To: <20180419181901.6584-1-jshraddha@vmware.com>

> -----Original Message-----
> From: Shraddha Joshi [mailto:jshraddha@vmware.com]
> Sent: Thursday, April 19, 2018 11:19 AM
> To: Yong Wang <yongwang@vmware.com>
> Cc: dev@dpdk.org; Shraddha Joshi <jshraddha@vmware.com>
> Subject: [PATCH] net/vmxnet3: increase rx data ring descriptor size
> 
> Vmxnet3 driver supports receive data ring viz. a set of small sized
> buffers that are always mapped by the emulation. If a packet fits into
> the receive data ring buffer, the emulation delivers the packet via the
> receive data ring.
> 
> Increasing the receive data ring descriptor size from 128 to 256
> showed performance gains as high as 5% for packets smaller than 256.
> 
> Signed-off-by: Shraddha Joshi <jshraddha@vmware.com>
> Acked-by: Jin Heo <heoj@vmware.com>
> Acked-by: Guolin Yang <gyang@vmware.com>
> Acked-by: Boon Ang <bang@vmware.com>

Acked-by: Yong Wang <yongwang@vmware.com>

> ---
>  drivers/net/vmxnet3/vmxnet3_ring.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_ring.h
> b/drivers/net/vmxnet3/vmxnet3_ring.h
> index 552180e84..50992349d 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ring.h
> +++ b/drivers/net/vmxnet3/vmxnet3_ring.h
> @@ -14,7 +14,7 @@
>  #define VMXNET3_DEF_RX_RING_SIZE 128
> 
>  /* Default rx data ring desc size */
> -#define VMXNET3_DEF_RXDATA_DESC_SIZE 128
> +#define VMXNET3_DEF_RXDATA_DESC_SIZE 256
> 
>  #define VMXNET3_SUCCESS 0
>  #define VMXNET3_FAIL   -1
> --
> 2.11.0


  reply	other threads:[~2018-04-19 21:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19 18:19 Shraddha Joshi
2018-04-19 21:54 ` Yong Wang [this message]
2018-04-19 22:57   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY2PR05MB235946D7E91FA0F0845F969DAFB50@BY2PR05MB2359.namprd05.prod.outlook.com \
    --to=yongwang@vmware.com \
    --cc=dev@dpdk.org \
    --cc=jshraddha@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).