From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"amorenoz@redhat.com" <amorenoz@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] vhost: remove unused Vhost virtqueue field
Date: Fri, 8 Jan 2021 04:59:24 +0000 [thread overview]
Message-ID: <BY5PR11MB405575DB6EA930466F6F8B5C9CAE0@BY5PR11MB4055.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201222135658.53916-2-maxime.coquelin@redhat.com>
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday, December 22, 2020 9:57 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; amorenoz@redhat.com
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH 1/3] vhost: remove unused Vhost virtqueue field
>
> This patch removes the "backend" field of the
> vhost_virtqueue struct, which is not used by the
> library.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> lib/librte_vhost/vhost.c | 2 --
> lib/librte_vhost/vhost.h | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
> index b83cf639eb..4e5df862aa 100644
> --- a/lib/librte_vhost/vhost.c
> +++ b/lib/librte_vhost/vhost.c
> @@ -557,8 +557,6 @@ init_vring_queue(struct virtio_net *dev, uint32_t
> vring_idx)
> vq->notif_enable = VIRTIO_UNINITIALIZED_NOTIF;
>
> vhost_user_iotlb_init(dev, vring_idx);
> - /* Backends are set to -1 indicating an inactive device. */
> - vq->backend = -1;
> }
>
> static void
> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> index 361c9f79b3..d132e4ae54 100644
> --- a/lib/librte_vhost/vhost.h
> +++ b/lib/librte_vhost/vhost.h
> @@ -143,8 +143,6 @@ struct vhost_virtqueue {
> #define VIRTIO_INVALID_EVENTFD (-1)
> #define VIRTIO_UNINITIALIZED_EVENTFD (-2)
>
> - /* Backend value to determine if device should started/stopped */
> - int backend;
> int enabled;
> int access_ok;
> int ready;
> --
> 2.29.2
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
next prev parent reply other threads:[~2021-01-08 4:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 13:56 [dpdk-dev] [PATCH 0/3] vhost: make virtqueue cache-friendly Maxime Coquelin
2020-12-22 13:56 ` [dpdk-dev] [PATCH 1/3] vhost: remove unused Vhost virtqueue field Maxime Coquelin
2021-01-08 4:59 ` Xia, Chenbo [this message]
2020-12-22 13:56 ` [dpdk-dev] [PATCH 2/3] vhost: move dirty logging cache out of the virtqueue Maxime Coquelin
2021-01-08 7:20 ` Xia, Chenbo
2021-03-16 12:25 ` Maxime Coquelin
2020-12-22 13:56 ` [dpdk-dev] [PATCH 3/3] vhost: optimize vhost virtqueue struct Maxime Coquelin
2021-01-08 7:28 ` Xia, Chenbo
2021-01-25 17:30 ` [dpdk-dev] [PATCH 0/3] vhost: make virtqueue cache-friendly Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB405575DB6EA930466F6F8B5C9CAE0@BY5PR11MB4055.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=amorenoz@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).