From: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Stephen Hemminger <sthemmin@microsoft.com>,
"Patil, Harish" <Harish.Patil@cavium.com>
Subject: Re: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity
Date: Wed, 19 Sep 2018 16:40:57 +0000 [thread overview]
Message-ID: <BYAPR07MB536568D99AA44A0E88ACAD919F1C0@BYAPR07MB5365.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20180918080715.17fcd7d8@xeon-e3>
>From: Stephen Hemminger <stephen@networkplumber.org>
>Sent: Tuesday, September 18, 2018 8:07 AM
>
>On Tue, 18 Sep 2018 11:40:28 +0200
>Thomas Monjalon <thomas@monjalon.net> wrote:
>
>> 25/07/2018 20:20, Stephen Hemminger:
>> > No need for profanity in comments.
>> >
>> > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
>> > ---
>> > drivers/net/bnx2x/elink.c | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
>> > index 34a29373af3b..08fe817720a1 100644
>> > --- a/drivers/net/bnx2x/elink.c
>> > +++ b/drivers/net/bnx2x/elink.c
>> > @@ -3993,11 +3993,11 @@ static elink_status_t
>elink_get_mod_abs_int_cfg(struct bnx2x_softc *sc,
>> > PORT_HW_CFG_E3_MOD_ABS_MASK) >>
>> > PORT_HW_CFG_E3_MOD_ABS_SHIFT;
>> >
>> > - /* Should not happen. This function called upon interrupt
>> > + /*
>> > + * Should not happen. This function called upon
>> > + interrupt
>> > * triggered by GPIO ( since EPIO can only generate interrupts
>> > * to MCP).
>> > * So if this function was called and none of the GPIOs was set,
>> > - * it means the shit hit the fan.
>> > */
>>
>> It makes the comment ends with a comma, like the end is missing.
>>
>>
>>
>
>Yes, better language would be.
> /* This should not happen since this function is called
> * from interrupt triggered by GPI ..
+1
I've re-worded the last bit.
/* This should not happen since this function is called
* from interrupt triggered by GPIO (since EPIO can only
* generate interrupts to MCP).
* So if this function was called and none of the GPIOs was set,
* it means something disastrous has already happened.
*/
Thanks!
-Rasesh
next prev parent reply other threads:[~2018-09-19 16:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 18:20 [dpdk-dev] [PATCH 0/4] small cleanups Stephen Hemminger
2018-07-25 18:20 ` [dpdk-dev] [PATCH 1/4] arm: remove profanity in comment Stephen Hemminger
2018-10-24 23:50 ` Thomas Monjalon
2018-07-25 18:20 ` [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity Stephen Hemminger
2018-09-18 9:40 ` Thomas Monjalon
2018-09-18 15:07 ` Stephen Hemminger
2018-09-19 16:40 ` Mody, Rasesh [this message]
2018-10-16 14:45 ` Ferruh Yigit
2018-10-16 14:52 ` Ferruh Yigit
2018-10-26 14:56 ` Burakov, Anatoly
2018-07-25 18:20 ` [dpdk-dev] [PATCH 3/4] eal: don't crash if alarm set fails Stephen Hemminger
2018-07-26 9:34 ` Burakov, Anatoly
2018-07-26 9:41 ` Burakov, Anatoly
2018-09-18 9:43 ` Thomas Monjalon
2018-09-18 10:16 ` Burakov, Anatoly
2018-10-24 23:51 ` Thomas Monjalon
2018-10-25 14:04 ` Burakov, Anatoly
2018-10-26 14:55 ` [dpdk-dev] [PATCH] eal/mp: remove rte_panic and profanity Anatoly Burakov
2018-10-26 20:41 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-10-30 10:31 ` Burakov, Anatoly
2018-11-13 18:03 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2018-11-13 23:03 ` Thomas Monjalon
2018-07-25 18:20 ` [dpdk-dev] [PATCH 4/4] ixgbe: remove mild profanity Stephen Hemminger
2018-10-16 15:00 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR07MB536568D99AA44A0E88ACAD919F1C0@BYAPR07MB5365.namprd07.prod.outlook.com \
--to=rasesh.mody@cavium.com \
--cc=Harish.Patil@cavium.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).