From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Xu, Ting" <ting.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v4] lib/table: fix cache alignment issue
Date: Wed, 22 Jul 2020 08:49:53 +0000 [thread overview]
Message-ID: <BYAPR11MB29353625C9B16EABF2713D2CEB790@BYAPR11MB2935.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CY4PR1101MB231015070338C942BE9013D5F8790@CY4PR1101MB2310.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Xu, Ting <ting.xu@intel.com>
> Sent: Wednesday, July 22, 2020 9:31 AM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH v4] lib/table: fix cache alignment issue
>
> Hi, Cristian,
>
> > -----Original Message-----
> > From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> > Sent: Wednesday, July 22, 2020 4:27 PM
> > To: Xu, Ting <ting.xu@intel.com>; dev@dpdk.org
> > Cc: stable@dpdk.org
> > Subject: RE: [PATCH v4] lib/table: fix cache alignment issue
> >
> >
> >
> > > +#ifdef RTE_ARCH_64
> > > struct rte_bucket_4_32 {
> > > /* Cache line 0 */
> > > uint64_t signature[4 + 1];
> > > @@ -46,6 +47,22 @@ struct rte_bucket_4_32 {
> > > /* Cache line 3 */
> > > uint8_t data[0];
> > > };
> > > +#else
> > > +struct rte_bucket_4_32 {
> > > + /* Cache line 0 */
> > > + uint64_t signature[4 + 1];
> > > + uint64_t lru_list;
> > > + struct rte_bucket_4_32 *next;
> > > + uint32_t pad;
> > > + uint64_t next_valid;
> > > +
> > > + /* Cache lines 1 and 2 */
> > > + uint64_t key[4][4];
> > > +
> > > + /* Cache line 3 */
> > > + uint8_t data[0];
> > > +};
> > > +#endif
> > >
> >
> > Hi Ting,
> >
> > Yes, it looks good, but as mentioned previously please do the same on the
> > other files in the same folder and add the changes to your patch, as we
> need
> > to keep all these files in sync:
> >
> > rte_table_hash_key8.c, struct rte_bucket_4_8 rte_table_hash_key32.c,
> struct
> > rte_bucket_4_32
> >
>
> I have did the changes to 8 and 32 bytes in this patch.
>
> > Thanks,
> > Cristian
Upss, sorry, somehow I missed it. I just acked this patch. Thanks, Ting!
Regards,
Cristian
next prev parent reply other threads:[~2020-07-22 8:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 16:27 [dpdk-stable] [PATCH v1] " Ting Xu
2020-06-17 5:43 ` [dpdk-stable] [PATCH v2] " Ting Xu
2020-07-02 8:06 ` [dpdk-stable] [dpdk-dev] " Zhou, JunX W
2020-07-09 1:48 ` [dpdk-stable] [PATCH v3] " Ting Xu
2020-07-20 14:37 ` Dumitrescu, Cristian
2020-07-21 5:15 ` Xu, Ting
2020-07-21 21:16 ` Dumitrescu, Cristian
2020-07-22 2:16 ` Xu, Ting
2020-07-22 2:16 ` [dpdk-stable] [PATCH v4] " Ting Xu
2020-07-22 8:26 ` Dumitrescu, Cristian
2020-07-22 8:30 ` Xu, Ting
2020-07-22 8:49 ` Dumitrescu, Cristian [this message]
2020-07-22 8:48 ` Dumitrescu, Cristian
2020-07-29 12:01 ` [dpdk-stable] [dpdk-dev] " David Marchand
2020-07-29 13:13 ` Dumitrescu, Cristian
2020-07-29 13:28 ` David Marchand
2020-07-29 13:54 ` Dumitrescu, Cristian
2020-07-29 13:59 ` David Marchand
2020-07-29 14:53 ` Dumitrescu, Cristian
2020-07-30 6:57 ` Xu, Ting
2020-07-30 10:35 ` Kevin Traynor
2020-09-09 6:18 ` Xu, Ting
2020-09-15 8:03 ` David Marchand
2020-10-14 8:26 ` Xu, Ting
2020-10-14 13:53 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB29353625C9B16EABF2713D2CEB790@BYAPR11MB2935.namprd11.prod.outlook.com \
--to=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=ting.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).