From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: "Daly, Jeff" <jeffd@silicom-usa.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Stephen Douthit <stephend@silicom-usa.com>,
"Daly, Jeff" <jeffd@silicom-usa.com>
Subject: RE: [PATCH v3] net/ixgbe: Retry SFP ID read field to handle misbehaving SFPs
Date: Thu, 24 Mar 2022 01:00:36 +0000 [thread overview]
Message-ID: <BYAPR11MB3495995FB20BFCF4D86D51F5F7199@BYAPR11MB3495.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220323200346.22318-1-jeffd@silicom-usa.com>
> -----Original Message-----
> From: jeffd@silicom-usa.com <jeffd@silicom-usa.com>
> Sent: Thursday, March 24, 2022 04:04
> To: dev@dpdk.org
> Cc: Stephen Douthit <stephend@silicom-usa.com>; Daly, Jeff <jeffd@silicom-usa.com>; Wang, Haiyue
> <haiyue.wang@intel.com>
> Subject: [PATCH v3] net/ixgbe: Retry SFP ID read field to handle misbehaving SFPs
>
> From: Stephen Douthit <stephend@silicom-usa.com>
>
> Some XGS-PON SFPs have been observed ACKing I2C reads and returning
> uninitialized garbage while their uC boots. This can lead to the SFP ID
> code marking an otherwise working SFP module as unsupported if a bogus
> ID value is read while its internal PHY/microcontroller is still
> booting.
>
> Retry the ID read several times looking not just for NAK, but also for a
> valid ID field.
>
> Since the device isn't NAKing the trasanction the existing longer retry
> code in ixgbe_read_i2c_byte_generic_int() doesn't apply here.
>
> Signed-off-by: Stephen Douthit <stephend@silicom-usa.com>
> Signed-off-by: Jeff Daly <jeffd@silicom-usa.com>
> ---
>
> Notes:
> v2:
> * Removed superfluous DEBUGOUT
> * Renamed id_reads to retries
> * Don't assume status == 0 means IXGBE_SUCCESS
>
> v3:
> * Removed extra braces around single statement if
>
> drivers/net/ixgbe/base/ixgbe_phy.c | 27 ++++++++++++++++++++++++---
> 1 file changed, 24 insertions(+), 3 deletions(-)
>
Thanks!
Reviewed-by: Haiyue Wang <haiyue.wang@intel.com>
> --
> 2.25.1
next prev parent reply other threads:[~2022-03-24 1:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 22:33 [PATCH] " jeffd
2022-03-17 6:55 ` Wang, Haiyue
2022-03-17 7:39 ` Wang, Haiyue
2022-03-22 15:24 ` [PATCH v2] " jeffd
2022-03-23 0:59 ` Wang, Haiyue
2022-03-23 20:03 ` [PATCH v3] " jeffd
2022-03-24 1:00 ` Wang, Haiyue [this message]
2022-03-24 8:40 ` Zhang, Qi Z
2022-03-25 9:54 ` [PATCH v4] net/ixgbe: retry SFP ID read " jeffd
2022-03-26 12:15 ` Wang, Haiyue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3495995FB20BFCF4D86D51F5F7199@BYAPR11MB3495.namprd11.prod.outlook.com \
--to=haiyue.wang@intel.com \
--cc=dev@dpdk.org \
--cc=jeffd@silicom-usa.com \
--cc=stephend@silicom-usa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).