From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
"stephend@silicom-usa.com" <stephend@silicom-usa.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Wang, Wen" <wenw@silicom-usa.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write
Date: Wed, 22 Dec 2021 01:24:12 +0000 [thread overview]
Message-ID: <BYAPR11MB3495CBCD530B3053A4A9B956F77D9@BYAPR11MB3495.namprd11.prod.outlook.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86D8B@smartserver.smartshare.dk>
> -----Original Message-----
> From: Morten Brørup <mb@smartsharesystems.com>
> Sent: Tuesday, December 21, 2021 16:58
> To: Wang, Haiyue <haiyue.wang@intel.com>; stephend@silicom-usa.com; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Changchun Ouyang <changchun.ouyang@intel.com>; Zhang, Helin <helin.zhang@intel.com>
> Cc: dev@dpdk.org; Wang, Wen <wenw@silicom-usa.com>; stable@dpdk.org
> Subject: RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write
>
> > From: Wang, Haiyue [mailto:haiyue.wang@intel.com]
> > Sent: Tuesday, 21 December 2021 02.15
> >
> > > -----Original Message-----
> > > From: Stephen Douthit <stephend@silicom-usa.com>
> > > Sent: Tuesday, December 21, 2021 05:33
> > >
> > > On 12/20/21 02:53, Wang, Haiyue wrote:
> > > >> -----Original Message-----
> > > >> From: Stephen Douthit <stephend@silicom-usa.com>
> > > >> Sent: Tuesday, December 7, 2021 06:19
> > > >>
> > > >> Make sure an SFP is really a SFF-8472 device that supports the
> > optional
> > > >> soft rate select feature before just blindly poking those I2C
> > registers.
> > > >>
> > > >> Skip all I2C traffic if we know there's no SFP.
> > > >>
> > > >> Fixes: f3430431aba ("ixgbe/base: add SFP+ dual-speed support")
> > > >> Cc: stable@dpdk.org
> > > >>
> > > >> Signed-off-by: Stephen Douthit <stephend@silicom-usa.com>
> > > >> ---
> > > >
> >
> > Normally, DPDK keeps sync with this kind of release.
> >
>
> Working with the Linux kernel mainline drivers is good advice.
>
> The official Intel Linux drivers seem to be ages behind the Kernel mainline, and they don't fully
No, the "ixgbe" drivers is updated on "7/8/2021".
https://www.intel.com/content/www/us/en/download/14302/14687/intel-network-adapter-driver-for-pcie-intel-10-gigabit-ethernet-network-connections-under-linux.html
> support the C3000 NICs, so don’t waste any time there! We recently tried using the official Intel
> Linux drivers for a C3338 based project (using Kernel 3.19 in 32 bit mode with x2APIC disabled), and
> they didn't work at all. We ended up backporting the necessary changes from the kernel mainline
> instead.
From Steve's response:
ME: "I guess this is just in C3000 reference board SDK ?"
Steve: "It's the board covered by Intel Doc # 574437."
I check the doc "Last Updated: 11/07/2018".... It should be some kind of customer release, that's why
they are not in the official *open source* Linux driver, so keep your patch set as private.
next prev parent reply other threads:[~2021-12-22 1:24 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211206221922.644187-1-stephend@silicom-usa.com>
2021-12-06 22:19 ` [PATCH v2 1/7] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs Stephen Douthit
2021-12-20 7:45 ` Wang, Haiyue
2021-12-20 21:32 ` Stephen Douthit
2021-12-06 22:19 ` [PATCH v2 2/7] net/ixgbe: Add ixgbe_check_sfp_cage() for testing state of PRSNT# signal Stephen Douthit
2021-12-06 22:19 ` [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write Stephen Douthit
2021-12-20 7:53 ` Wang, Haiyue
2021-12-20 21:32 ` Stephen Douthit
2021-12-21 1:15 ` Wang, Haiyue
2021-12-21 8:57 ` Morten Brørup
2021-12-22 1:24 ` Wang, Haiyue [this message]
2021-12-22 10:43 ` Morten Brørup
2021-12-22 16:03 ` Wang, Haiyue
2021-12-22 19:13 ` Morten Brørup
2021-12-22 21:44 ` Stephen Douthit
2021-12-23 0:55 ` Wang, Haiyue
2022-01-18 21:06 ` Stephen Douthit
2022-01-19 0:31 ` Wang, Haiyue
2022-02-07 16:04 ` Ferruh Yigit
2022-02-08 13:50 ` Jeff Daly
2022-02-08 14:52 ` Ferruh Yigit
2022-02-09 4:00 ` Wang, Haiyue
2022-02-09 13:33 ` Ferruh Yigit
2022-02-09 13:43 ` Wang, Haiyue
2021-12-21 14:05 ` Stephen Douthit
2021-12-06 22:19 ` [PATCH v2 4/7] net/ixgbe: Run 82599 link status workaround only on affected devices Stephen Douthit
2021-12-06 22:19 ` [PATCH v2 5/7] net/ixgbe: Fix SFP detection and linking on hotplug Stephen Douthit
2022-02-07 16:07 ` Ferruh Yigit
[not found] ` <20220224152357.12277-1-jeffd@silicom-usa.com>
2022-02-24 15:23 ` [PATCH v3 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs Jeff Daly
2022-02-24 15:23 ` [PATCH v3 2/3] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Jeff Daly
2022-02-24 15:23 ` [PATCH v3 3/3] net/ixgbe: Fix SFP detection and linking on hotplug Jeff Daly
2022-02-25 1:56 ` Wang, Haiyue
2022-02-25 20:50 ` [PATCH v4 " Jeff Daly
2022-02-26 15:57 ` Ferruh Yigit
[not found] ` <20220228152937.21247-1-jeffd@silicom-usa.com>
2022-02-28 15:29 ` [PATCH v4 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs Jeff Daly
2022-03-01 5:56 ` Wang, Haiyue
2022-03-01 11:18 ` Zhang, Qi Z
2022-03-06 17:56 ` Thomas Monjalon
2022-03-08 15:01 ` Jeff Daly
2022-02-28 15:29 ` [PATCH v4 2/3] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Jeff Daly
2022-02-28 15:29 ` [PATCH v4 3/3] net/ixgbe: Fix SFP detection and linking on hotplug Jeff Daly
2022-03-12 13:03 ` Jeff Daly
[not found] ` <20220412173445.30810-1-jeffd@silicom-usa.com>
2022-04-12 17:34 ` [PATCH v5 1/2] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Jeff Daly
2022-04-12 17:34 ` [PATCH v5 2/2] net/ixgbe: Fix SFP detection and linking on hotplug Jeff Daly
[not found] ` <20220412174220.31195-1-jeffd@silicom-usa.com>
2022-04-12 17:42 ` [PATCH v6 1/2] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Jeff Daly
2022-04-13 1:21 ` Wang, Haiyue
2022-04-13 15:32 ` Jeff Daly
2022-04-14 1:56 ` Wang, Haiyue
2022-04-12 17:42 ` [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug Jeff Daly
2022-04-13 2:46 ` Wang, Haiyue
2022-04-13 6:57 ` Morten Brørup
2022-04-13 7:01 ` Wang, Haiyue
2022-04-13 7:19 ` Morten Brørup
2022-04-13 11:49 ` Wang, Haiyue
2022-04-13 12:54 ` Morten Brørup
2022-04-13 15:23 ` Jeff Daly
2022-04-14 10:49 ` Jeff Daly
2022-04-14 11:08 ` Jeff Daly
2022-04-14 2:49 ` Wang, Haiyue
2022-04-14 2:59 ` Wang, Haiyue
2022-04-14 10:40 ` Jeff Daly
2022-04-14 12:11 ` Wang, Haiyue
2022-04-18 21:54 ` Jeff Daly
2022-04-19 2:05 ` Wang, Haiyue
2022-04-19 17:33 ` Jeff Daly
2022-04-20 1:09 ` Wang, Haiyue
2022-04-21 17:31 ` Jeff Daly
2022-04-22 2:11 ` Wang, Haiyue
2022-05-12 1:26 ` Zhang, Qi Z
2022-05-25 16:55 ` Jeff Daly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3495CBCD530B3053A4A9B956F77D9@BYAPR11MB3495.namprd11.prod.outlook.com \
--to=haiyue.wang@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=mb@smartsharesystems.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=stephend@silicom-usa.com \
--cc=wenw@silicom-usa.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).