DPDK patches and discussions
 help / color / mirror / Atom feed
From: Gregory Etelson <getelson@nvidia.com>
To: David Marchand <david.marchand@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	Xiaoyun Li <xiaoyun.li@intel.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: remove warning on flex flow flush
Date: Tue, 2 Nov 2021 19:39:58 +0000	[thread overview]
Message-ID: <BYAPR12MB26316EA9F1F90845269AE56CA58B9@BYAPR12MB2631.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211102183848.32422-1-david.marchand@redhat.com>

Hello,

I posted a patch for that issue in
https://patchwork.dpdk.org/project/dpdk/patch/20211026152000.11665-1-getelson@nvidia.com/

Regards,
Gregory

> -----Original Message-----
> From: David Marchand
> <david.marchand@redhat.com>
> Sent: Tuesday, November 2, 2021 20:39
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>;
> ferruh.yigit@intel.com; NBU-Contact-Thomas
> Monjalon <thomas@monjalon.net>; Xiaoyun Li
> <xiaoyun.li@intel.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Subject: [PATCH] app/testpmd: remove warning
> on flex flow flush
> 
> External email: Use caution opening links or
> attachments
> 
> 
> Building DPDK without JSON, warnings get
> displayed when stopping testpmd
> without entering any flex flow rule.
> 
> Fixes: 59f3a8acbcdb ("app/testpmd: add flex
> item commands")
> 
> Signed-off-by: David Marchand
> <david.marchand@redhat.com>
> ---
>  app/test-pmd/cmd_flex_item.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/app/test-pmd/cmd_flex_item.c
> b/app/test-pmd/cmd_flex_item.c
> index 45103e45a8..337dcdd565 100644
> --- a/app/test-pmd/cmd_flex_item.c
> +++ b/app/test-pmd/cmd_flex_item.c
> @@ -415,6 +415,8 @@
> port_flex_item_flush(portid_t port_id)
>         uint16_t i;
> 
>         for (i = 0; i < FLEX_MAX_PARSERS_NUM;
> i++) {
> +               if (flex_items[port_id][i] == NULL)
> +                       continue;
>                 flex_item_destroy(port_id, i);
>                 flex_items[port_id][i] = NULL;
>         }
> --
> 2.23.0


  reply	other threads:[~2021-11-02 19:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02 18:38 David Marchand
2021-11-02 19:39 ` Gregory Etelson [this message]
2021-11-02 19:44   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR12MB26316EA9F1F90845269AE56CA58B9@BYAPR12MB2631.namprd12.prod.outlook.com \
    --to=getelson@nvidia.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).