patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@nvidia.com>
To: Gregory Etelson <getelson@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Subject: RE: [PATCH] common/mlx5: fix shared mempool subscription
Date: Sun, 6 Nov 2022 11:08:35 +0000	[thread overview]
Message-ID: <BYAPR12MB307861147809DCCD06702C7ACF3D9@BYAPR12MB3078.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20221103104427.1677-1-getelson@nvidia.com>

Hi,

> -----Original Message-----
> From: Gregory Etelson <getelson@nvidia.com>
> Sent: Thursday, November 3, 2022 12:44 PM
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org; Slava Ovsiienko <viacheslavo@nvidia.com>; Anatoly
> Burakov <anatoly.burakov@intel.com>; Dmitry Kozlyuk
> <dkozlyuk@nvidia.com>
> Subject: [PATCH] common/mlx5: fix shared mempool subscription
> 
> MLX5 PMD counted each mempool subscribe invocation. The PMD expected
> that the mempool subscription will be deleted after the mempool counter
> dropped to 0. However, current PMD design unsubscribes mempool
> callbacks only once.
> As the result, the PMD destroyed mlx5_common_device but kept shared RX
> subscription callback. EAL tried to activate that callback and crashed.
> 
> The patch removes mempool subscriptions counter.
> The PMD registers mempool subscription once only. An attempt to register
> existing subscription returns EEXIST.
> Also, the PMD expects to remove subscription when mempool unsubscribe
> was activated.
> 
> Fixes: 8ad97e4b3215 ("common/mlx5: fix multi-process mempool
> registration")
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

      reply	other threads:[~2022-11-06 11:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 10:44 Gregory Etelson
2022-11-06 11:08 ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR12MB307861147809DCCD06702C7ACF3D9@BYAPR12MB3078.namprd12.prod.outlook.com \
    --to=rasland@nvidia.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=dkozlyuk@nvidia.com \
    --cc=getelson@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).