From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: Harman Kalra <hkalra@marvell.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Vamsi Krishna Attunuru <vattunuru@marvell.com>,
Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/octeontx2: support read clock API
Date: Sun, 28 Jul 2019 07:43:55 +0000 [thread overview]
Message-ID: <BYAPR18MB24244BF96ABE9E49C9E6703CC8C20@BYAPR18MB2424.namprd18.prod.outlook.com> (raw)
In-Reply-To: <1564260052-28926-2-git-send-email-hkalra@marvell.com>
> -----Original Message-----
> From: Harman Kalra <hkalra@marvell.com>
> Sent: Sunday, July 28, 2019 2:11 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin Kumar Dabilpuram
> <ndabilpuram@marvell.com>; Vamsi Krishna Attunuru
> <vattunuru@marvell.com>; Kiran Kumar Kokkilagadda
> <kirankumark@marvell.com>
> Cc: dev@dpdk.org; Harman Kalra <hkalra@marvell.com>
> Subject: [PATCH v2 2/2] net/octeontx2: support read clock API
>
> This patch implements read clock api whose purpose is to return raw clock ticks.
> Using this API real time ticks spent in processing a packet can be known:
> <read_clock val at any time> - mbuf->timestamp
>
> Calling mbox for reading raw clock ticks in fastpath is very expensive so its value
> is derived from time stamp counter(tsc) using freq multipler (ratio of raw clock
> ticks and tsc) and clock delta (by how much tsc is lagging from raw clock value).
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
> ---
> V2:
> * More detailed commit message
> * changed rdtsc to tsc (timestamp counter)
> * Initialized a variable to zero only when needed
> * changed done label to fail
>
> drivers/common/octeontx2/otx2_mbox.h | 2 +
> drivers/net/octeontx2/otx2_ethdev.c | 89 ++++++++++++++++++++++++++++
Move as much changes to otx2_ptp.c, rest it looks good to me.
next prev parent reply other threads:[~2019-07-28 7:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 14:57 [dpdk-dev] [PATCH 1/2] net/octeontx2: fix ptp performance issue Harman Kalra
2019-07-27 14:57 ` [dpdk-dev] [PATCH 2/2] net/octeontx2: support read clock API Harman Kalra
2019-07-27 15:48 ` Jerin Jacob Kollanukkaran
2019-07-27 20:41 ` [dpdk-dev] [PATCH v2 1/2] net/octeontx2: fix ptp performance issue Harman Kalra
2019-07-27 20:41 ` [dpdk-dev] [PATCH v2 2/2] net/octeontx2: support read clock API Harman Kalra
2019-07-28 7:43 ` Jerin Jacob Kollanukkaran [this message]
2019-07-28 9:09 ` [dpdk-dev] [PATCH v3 1/2] net/octeontx2: fix ptp performance issue Harman Kalra
2019-07-28 9:09 ` [dpdk-dev] [PATCH v3 2/2] net/octeontx2: support read clock API Harman Kalra
2019-07-28 16:52 ` [dpdk-dev] [PATCH v3 1/2] net/octeontx2: fix ptp performance issue Jerin Jacob Kollanukkaran
2019-07-27 17:14 [dpdk-dev] [PATCH] examples/rxtx_callbacks: fix HW timestamp enable Jerin Jacob Kollanukkaran
2019-07-27 20:34 ` [dpdk-dev] [PATCH v2 1/2] net/octeontx2: fix ptp performance issue Harman Kalra
2019-07-27 20:34 ` [dpdk-dev] [PATCH v2 2/2] net/octeontx2: support read clock API Harman Kalra
2019-07-27 20:27 [dpdk-dev] [PATCH v2 1/2] net/octeontx2: fix ptp performance issue Harman Kalra
2019-07-27 20:27 ` [dpdk-dev] [PATCH v2 2/2] net/octeontx2: support read clock API Harman Kalra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB24244BF96ABE9E49C9E6703CC8C20@BYAPR18MB2424.namprd18.prod.outlook.com \
--to=jerinj@marvell.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).