From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: add build check on fast path fields
Date: Thu, 18 Jul 2019 13:31:22 +0000 [thread overview]
Message-ID: <BYAPR18MB24249F0E601B6723FFE64D58C8C80@BYAPR18MB2424.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190718130931.99036-1-ndabilpuram@marvell.com>
> -----Original Message-----
> From: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Sent: Thursday, July 18, 2019 6:40 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin Kumar
> Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda
> <kirankumark@marvell.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] net/octeontx2: add build check on fast path fields
>
> Add build bug on on fast path used fields that are dependent on their
> positions and values.
>
> Fixes: 920717e4d8ba ("net/octeontx2: add device start operation")
Please point Fixes changes where we can add the fast path code.
> Cc: ndabilpuram@marvell.com
This Cc can be removed as you are the author.
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> ---
> drivers/net/octeontx2/otx2_ethdev.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/net/octeontx2/otx2_ethdev.c
> b/drivers/net/octeontx2/otx2_ethdev.c
> index fcb1869..77bf9aa 100644
> --- a/drivers/net/octeontx2/otx2_ethdev.c
> +++ b/drivers/net/octeontx2/otx2_ethdev.c
> @@ -586,6 +586,24 @@ nix_tx_offload_flags(struct rte_eth_dev *eth_dev)
> RTE_BUILD_BUG_ON(PKT_TX_TCP_CKSUM != (1ULL << 52));
> RTE_BUILD_BUG_ON(PKT_TX_SCTP_CKSUM != (2ULL << 52));
> RTE_BUILD_BUG_ON(PKT_TX_UDP_CKSUM != (3ULL << 52));
> + RTE_BUILD_BUG_ON(PKT_TX_IP_CKSUM != (1ULL << 54));
> + RTE_BUILD_BUG_ON(PKT_TX_IPV4 != (1ULL << 55));
> + RTE_BUILD_BUG_ON(PKT_TX_OUTER_IP_CKSUM != (1ULL << 58));
> + RTE_BUILD_BUG_ON(PKT_TX_OUTER_IPV4 != (1ULL << 59));
> + RTE_BUILD_BUG_ON(PKT_TX_OUTER_IPV6 != (1ULL << 60));
> + RTE_BUILD_BUG_ON(PKT_TX_OUTER_UDP_CKSUM != (1ULL <<
> 41));
> + RTE_BUILD_BUG_ON(RTE_MBUF_L2_LEN_BITS != 7);
> + RTE_BUILD_BUG_ON(RTE_MBUF_L3_LEN_BITS != 9);
> + RTE_BUILD_BUG_ON(RTE_MBUF_OUTL2_LEN_BITS != 7);
> + RTE_BUILD_BUG_ON(RTE_MBUF_OUTL3_LEN_BITS != 9);
> + RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_off) !=
> + offsetof(struct rte_mbuf, buf_iova) + 8);
> + RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, ol_flags) !=
> + offsetof(struct rte_mbuf, buf_iova) + 16);
> + RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, pkt_len) !=
> + offsetof(struct rte_mbuf, ol_flags) + 12);
> + RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, tx_offload) !=
> + offsetof(struct rte_mbuf, pool) + 2 * sizeof(void *));
>
> if (conf & DEV_TX_OFFLOAD_VLAN_INSERT ||
> conf & DEV_TX_OFFLOAD_QINQ_INSERT)
> --
> 2.8.4
next prev parent reply other threads:[~2019-07-18 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 13:09 Nithin Dabilpuram
2019-07-18 13:31 ` Jerin Jacob Kollanukkaran [this message]
2019-07-18 13:46 ` [dpdk-dev] [PATCH v2] " Nithin Dabilpuram
2019-07-22 8:09 ` Jerin Jacob Kollanukkaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB24249F0E601B6723FFE64D58C8C80@BYAPR18MB2424.namprd18.prod.outlook.com \
--to=jerinj@marvell.com \
--cc=dev@dpdk.org \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).