DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: Liron Himi <lironh@marvell.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Liron Himi <lironh@marvell.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on	armv8-a
Date: Sat, 18 May 2019 10:59:05 +0000	[thread overview]
Message-ID: <BYAPR18MB2424EF14AA42BBA4BBF32506C8040@BYAPR18MB2424.namprd18.prod.outlook.com> (raw)
In-Reply-To: <1558128867-15941-2-git-send-email-lironh@marvell.com>

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of lironh@marvell.com
> Sent: Saturday, May 18, 2019 3:04 AM
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; Liron Himi <lironh@marvell.com>
> Subject: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based
> on armv8-a
> 
> From: Liron Himi <lironh@marvell.com>
> 
> This patch introduces armada target to address difference in number of cores,
> no numa support
> 
> Signed-off-by: Liron Himi <lironh@marvell.com>
> Reviewed-by: Alan Winkowski <walan@marvell.com>
> Tested-by: Liron Himi <lironh@marvell.com>
> ---
>  config/defconfig_arm64-armada-linux-gcc    | 24 ++++++++++++++++++++++++
>  config/defconfig_arm64-armada-linuxapp-gcc | 24 ++++++++++++++++++++++++

Don't create a new file for linuxapp-gcc, instead make sym link like other armv8 config.

>  2 files changed, 48 insertions(+)
>  create mode 100644 config/defconfig_arm64-armada-linux-gcc
>  create mode 100644 config/defconfig_arm64-armada-linuxapp-gcc
> 
> diff --git a/config/defconfig_arm64-armada-linux-gcc
> b/config/defconfig_arm64-armada-linux-gcc
> new file mode 100644
> index 0000000..573b278
> --- /dev/null
> +++ b/config/defconfig_arm64-armada-linux-gcc
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Marvell

s/2018/2019

> +International Ltd #
> +
> +#include "defconfig_arm64-armv8a-linux-gcc"
> +
> +CONFIG_RTE_LIBRTE_MVEP_COMMON=y
> +CONFIG_RTE_LIBRTE_MVPP2_PMD=y
> +CONFIG_RTE_LIBRTE_MVNETA_PMD=y
> +CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
> +
> +#
> +# Compile Environment Abstraction Layer #
> +CONFIG_RTE_MAX_LCORE=16e 
> +CONFIG_RTE_MAX_NUMA_NODES=1
> +CONFIG_RTE_CACHE_LINE_SIZE=64

Please move this section first, to have symmetry  with other armv8 config file
i.e

# core changes
# PMD changes

With above changes:
Acked-by: Jerin Jacob <jerinj@marvell.com>


  reply	other threads:[~2019-05-18 10:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 21:34 [dpdk-dev] [PATCH 0/2] Introduces armada target lironh
2019-05-17 21:34 ` [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a lironh
2019-05-18 10:59   ` Jerin Jacob Kollanukkaran [this message]
2019-05-24  7:50   ` Ruifeng Wang (Arm Technology China)
2019-05-26  5:33     ` Liron Himi
2019-05-17 21:34 ` [dpdk-dev] [PATCH 2/2] meson: " lironh
  -- strict thread matches above, loose matches on Subject: below --
2019-05-17 21:27 [dpdk-dev] [PATCH 0/2] Introduces armada target lironh
2019-05-17 21:27 ` [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a lironh
2019-05-22  9:11   ` Ruifeng Wang (Arm Technology China)
2019-05-22  9:12     ` Liron Himi
2019-05-23 10:11   ` Ruifeng Wang (Arm Technology China)
2019-05-23 10:51     ` Liron Himi
2019-05-24  1:10       ` Ruifeng Wang (Arm Technology China)
2019-05-24 13:06         ` Ferruh Yigit
2019-05-27  1:42           ` Ruifeng Wang (Arm Technology China)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR18MB2424EF14AA42BBA4BBF32506C8040@BYAPR18MB2424.namprd18.prod.outlook.com \
    --to=jerinj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=lironh@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).