DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	Vamsi Krishna Attunuru <vattunuru@marvell.com>,
	John McNamara <john.mcnamara@intel.com>,
	Marko Kovacevic <marko.kovacevic@intel.com>,
	Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
	Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] common/octeontx2: add CNF95xx SoC support
Date: Thu, 11 Jul 2019 11:56:26 +0000	[thread overview]
Message-ID: <BYAPR18MB2424F504F684F0D90693836DC8F30@BYAPR18MB2424.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190710170142.142517-1-ndabilpuram@marvell.com>

> -----Original Message-----
> From: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Sent: Wednesday, July 10, 2019 10:32 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin Kumar
> Dabilpuram <ndabilpuram@marvell.com>; Vamsi Krishna Attunuru
> <vattunuru@marvell.com>; John McNamara <john.mcnamara@intel.com>;
> Marko Kovacevic <marko.kovacevic@intel.com>; Pavan Nikhilesh
> Bhagavatula <pbhagavatula@marvell.com>; Kiran Kumar Kokkilagadda
> <kirankumark@marvell.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] common/octeontx2: add CNF95xx SoC support
> 
> Update platform support of CNF95xx in documentation and also, update the
> HW cap based on PCI subsystem id and revision id.
> This patch also changes HW capability handling to be based on PCI Revision
> ID. PCI Revision ID contains a unique identifier to identify chip, major and
> minor revisions.
> 
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
>  	pci_dev = container_of(event_dev->dev, struct rte_pci_device,
> device);
> +	rc = rte_pci_read_config(pci_dev, &rev_id, 1,
> RVU_PCI_REVISION_ID);
> +	if (rc != 1) {
> +		otx2_err("Failed to read pci revision id, rc=%d", rc);
> +		goto error;
> +	}

Please remove this code duplication in all the drivers.

Other that it looks good to me.


  reply	other threads:[~2019-07-11 11:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10 17:01 Nithin Dabilpuram
2019-07-11 11:56 ` Jerin Jacob Kollanukkaran [this message]
2019-07-12  9:25 ` [dpdk-dev] [PATCH v2] " Nithin Dabilpuram
2019-07-12 12:37   ` Jerin Jacob Kollanukkaran
2019-07-14 13:44     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR18MB2424F504F684F0D90693836DC8F30@BYAPR18MB2424.namprd18.prod.outlook.com \
    --to=jerinj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=kirankumark@marvell.com \
    --cc=marko.kovacevic@intel.com \
    --cc=ndabilpuram@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=vattunuru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).