From: Rasesh Mody <rmody@marvell.com>
To: Kevin Traynor <ktraynor@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] [PATCH] net/qede: support IOVA VA mode
Date: Thu, 7 Mar 2019 21:09:40 +0000 [thread overview]
Message-ID: <BYAPR18MB2838C77216E3C1EF20DECEFDB54C0@BYAPR18MB2838.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190307183903.10779-1-ktraynor@redhat.com>
>From: Kevin Traynor <ktraynor@redhat.com>
>Sent: Thursday, March 07, 2019 10:39 AM
>
>----------------------------------------------------------------------
>Set RTE_PCI_DRV_IOVA_AS_VA in drv_flags. This allows initializing qede PMD
>as non-root also on Linux v4.x, where /proc/self/pagemap can't be acccessed
>without CAP_SYS_ADMIN privileges.
>
>The flag was introduced generically but not in pmds in commit:
>815c7deaed2d ("pci: get IOMMU class on Linux")
>
>Cc: stable@dpdk.org
>
>Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>---
Acked-by: Rasesh Mody <rmody@marvell.com>
>
> drivers/net/qede/qede_ethdev.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/qede/qede_ethdev.c
>b/drivers/net/qede/qede_ethdev.c index 518673dce..6b330c2b2 100644
>--- a/drivers/net/qede/qede_ethdev.c
>+++ b/drivers/net/qede/qede_ethdev.c
>@@ -2736,5 +2736,6 @@ static int qedevf_eth_dev_pci_remove(struct
>rte_pci_device *pci_dev) static struct rte_pci_driver rte_qedevf_pmd = {
> .id_table = pci_id_qedevf_map,
>- .drv_flags = RTE_PCI_DRV_NEED_MAPPING |
>RTE_PCI_DRV_INTR_LSC,
>+ .drv_flags = RTE_PCI_DRV_NEED_MAPPING
>|RTE_PCI_DRV_INTR_LSC |
>+ RTE_PCI_DRV_IOVA_AS_VA,
> .probe = qedevf_eth_dev_pci_probe,
> .remove = qedevf_eth_dev_pci_remove,
>@@ -2755,5 +2756,6 @@ static int qede_eth_dev_pci_remove(struct
>rte_pci_device *pci_dev) static struct rte_pci_driver rte_qede_pmd = {
> .id_table = pci_id_qede_map,
>- .drv_flags = RTE_PCI_DRV_NEED_MAPPING |
>RTE_PCI_DRV_INTR_LSC,
>+ .drv_flags = RTE_PCI_DRV_NEED_MAPPING |
>RTE_PCI_DRV_INTR_LSC |
>+ RTE_PCI_DRV_IOVA_AS_VA,
> .probe = qede_eth_dev_pci_probe,
> .remove = qede_eth_dev_pci_remove,
>--
>2.20.1
next prev parent reply other threads:[~2019-03-07 21:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 18:39 [dpdk-dev] " Kevin Traynor
2019-03-07 21:09 ` Rasesh Mody [this message]
2019-03-08 5:15 ` Shahed Shaikh
2019-03-08 9:28 ` [dpdk-dev] [PATCH v2] " Kevin Traynor
2019-03-15 18:18 ` Ferruh Yigit
2019-03-15 18:18 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB2838C77216E3C1EF20DECEFDB54C0@BYAPR18MB2838.namprd18.prod.outlook.com \
--to=rmody@marvell.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).