DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5] vfio: Support for no-IOMMU mode
Date: Thu, 28 Jan 2016 10:03:06 +0000	[thread overview]
Message-ID: <C6ECDF3AB251BE4894318F4E45123697820C5395@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <7496408.z4nt1qSYiL@xps13>

> 2016-01-27 16:50, Anatoly Burakov:
> > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > +int vfio_type1_dma_map(int);
> > +int vfio_noiommu_dma_map(int);
> 
> WARNING:AVOID_EXTERNS: externs should be avoided in .c files I agree with
> checkpatch, they should be static ;)
> 

Will fix that.

> > --- a/lib/librte_eal/linuxapp/eal/eal_vfio.h
> > +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.h
> > +/* older kernels may not have no-IOMMU mode */ #ifndef
> > +VFIO_NOIOMMU_IOMMU #define VFIO_NOIOMMU_IOMMU 8 #endif
> 
> Shouldn't it be defined privately in .c file?

We already have other VFIO-related definitions in that file, specifically the PCI defines that aren't present in earlier kernels. This definition is similar in nature - it will be present in kernels starting from 4.5 (when NOIOMMU was introduced), but earlier kernels will need this defined. I didn't want to go similar route with redefining everything VFIO-related, but maybe it makes sense in this case for consistency's sake? E.g.

#define RTE_VFIO_TYPE1 VFIO_TYPE1_IOMMU [we're already in an ifdef linux >= 3.6, so define type1 unconditionally]
#if linux < 4.5
#define RTE_VFIO_NOIOMMU 8
#else
#define RTE_VFIO_NOIOMMU VFIO_NOIOMMU_IOMMU
#endif

Or something like that?

Thanks,
Anatoly

  reply	other threads:[~2016-01-28 10:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-21 20:16 [dpdk-dev] [PATCH] " Anatoly Burakov
2016-01-13 12:36 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2016-01-13 16:45   ` Stephen Hemminger
2016-01-14  9:50     ` Burakov, Anatoly
2016-01-27  9:05   ` Thomas Monjalon
2016-01-27 10:08     ` Burakov, Anatoly
2016-01-27 10:12       ` Thomas Monjalon
2016-01-27 10:24         ` David Marchand
2016-01-27 10:29           ` Burakov, Anatoly
2016-01-27 14:04   ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
2016-01-27 14:23     ` Burakov, Anatoly
2016-01-27 14:32     ` [dpdk-dev] [PATCH v4] " Anatoly Burakov
2016-01-27 15:50       ` Thomas Monjalon
2016-01-27 16:01         ` Burakov, Anatoly
2016-01-27 16:30           ` Burakov, Anatoly
2016-01-27 16:50       ` [dpdk-dev] [PATCH v5] " Anatoly Burakov
2016-01-27 17:07         ` Thomas Monjalon
2016-01-28 10:03           ` Burakov, Anatoly [this message]
2016-01-28 13:27             ` Thomas Monjalon
2016-01-28 11:57         ` [dpdk-dev] [PATCH v6] " Anatoly Burakov
2016-01-28 13:58           ` Thomas Monjalon
2016-01-28 14:16             ` Burakov, Anatoly
2016-01-28 14:40               ` Thomas Monjalon
2016-01-28 15:00                 ` Burakov, Anatoly
2016-01-28 16:55           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C6ECDF3AB251BE4894318F4E45123697820C5395@IRSMSX109.ger.corp.intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).