From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: "Rao, Nikhil" <nikhil.rao@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] vfio: Fix vfio disable INTx
Date: Tue, 28 Mar 2017 15:28:50 +0000 [thread overview]
Message-ID: <C6ECDF3AB251BE4894318F4E451236978220A553@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <1490745247-32001-1-git-send-email-nikhil.rao@intel.com>
> From: Rao, Nikhil
> Sent: Wednesday, March 29, 2017 12:54 AM
> To: Burakov, Anatoly <anatoly.burakov@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH v2] vfio: Fix vfio disable INTx
>
> The flags member of irq_set should be ORed with
> VFIO_IRQ_SET_ACTION_MASK and not VFIO_IRQ_SET_ACTION_UNMASK.
> The bug was found by code inspection.
>
> Fixes: 5c782b3928b8 (\"vfio: interrupts\")
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Great find!
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
next prev parent reply other threads:[~2017-03-28 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 23:15 [dpdk-dev] [PATCH] vfio: Fix vfio ioctl call to mask INTx Nikhil Rao
2017-03-28 23:54 ` [dpdk-dev] [PATCH v2] vfio: Fix vfio disable INTx Nikhil Rao
2017-03-28 15:28 ` Burakov, Anatoly [this message]
2017-03-30 15:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6ECDF3AB251BE4894318F4E451236978220A553@IRSMSX109.ger.corp.intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).