From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Jonas Pfefferle <jpf@zurich.ibm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "aik@ozlabs.ru" <aik@ozlabs.ru>
Subject: Re: [dpdk-dev] [PATCH v4] vfio: fix sPAPR IOMMU DMA window size
Date: Tue, 8 Aug 2017 12:06:12 +0000 [thread overview]
Message-ID: <C6ECDF3AB251BE4894318F4E4512369782271CF9@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <1502191002-13988-1-git-send-email-jpf@zurich.ibm.com>
> From: Jonas Pfefferle [mailto:jpf@zurich.ibm.com]
> Sent: Tuesday, August 8, 2017 12:17 PM
> To: Burakov, Anatoly <anatoly.burakov@intel.com>
> Cc: dev@dpdk.org; aik@ozlabs.ru; Jonas Pfefferle <jpf@zurich.ibm.com>
> Subject: [PATCH v4] vfio: fix sPAPR IOMMU DMA window size
>
> DMA window size needs to be big enough to span all memory segment's
> physical addresses. We do not need multiple levels of IOMMU tables as we
> already span ~70TB of physical memory with 16MB hugepages.
>
> Signed-off-by: Jonas Pfefferle <jpf@zurich.ibm.com>
> ---
> v2:
> * roundup to next power 2 function without loop.
>
> v3:
> * Replace roundup_next_pow2 with rte_align64pow2
>
> v4:
> * do not assume ordering of physical addresses of memsegs
>
> lib/librte_eal/linuxapp/eal/eal_vfio.c | 20 +++++++++++++++++---
> 1 file changed, 17 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c
> b/lib/librte_eal/linuxapp/eal/eal_vfio.c
> index 946df7e..7d5d61d 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_vfio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c
> @@ -759,10 +759,19 @@ vfio_spapr_dma_map(int vfio_container_fd)
> return -1;
> }
>
> - /* calculate window size based on number of hugepages configured
> */
> - create.window_size = rte_eal_get_physmem_size();
> + /* create DMA window from 0 to max(phys_addr + len) */
> + for (i = 0; i < RTE_MAX_MEMSEG; i++) {
> + if (ms[i].addr == NULL)
> + break;
> +
> + create.window_size = RTE_MAX(create.window_size,
> + ms[i].phys_addr + ms[i].len);
> + }
> +
> + /* sPAPR requires window size to be a power of 2 */
> + create.window_size = rte_align64pow2(create.window_size);
> create.page_shift = __builtin_ctzll(ms->hugepage_sz);
> - create.levels = 2;
> + create.levels = 1;
>
> ret = ioctl(vfio_container_fd, VFIO_IOMMU_SPAPR_TCE_CREATE,
> &create);
> if (ret) {
> @@ -771,6 +780,11 @@ vfio_spapr_dma_map(int vfio_container_fd)
> return -1;
> }
>
> + if (create.start_addr != 0) {
> + RTE_LOG(ERR, EAL, " DMA window start address != 0\n");
> + return -1;
> + }
> +
> /* map all DPDK segments for DMA. use 1:1 PA to IOVA mapping */
> for (i = 0; i < RTE_MAX_MEMSEG; i++) {
> struct vfio_iommu_type1_dma_map dma_map;
> --
> 2.7.4
Acked by: Anatoly Burakov <anatoly.burakov@intel.com>
Thanks,
Anatoly
next prev parent reply other threads:[~2017-08-08 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 11:16 Jonas Pfefferle
2017-08-08 12:06 ` Burakov, Anatoly [this message]
2017-10-10 13:33 ` Thomas Monjalon
2017-08-10 6:03 ` Alexey Kardashevskiy
2017-10-10 8:02 ` Jonas Pfefferle1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6ECDF3AB251BE4894318F4E4512369782271CF9@IRSMSX109.ger.corp.intel.com \
--to=anatoly.burakov@intel.com \
--cc=aik@ozlabs.ru \
--cc=dev@dpdk.org \
--cc=jpf@zurich.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).